Skip to content

Sflow fixes during DEL processing#1427

Merged
prsunny merged 1 commit intosonic-net:masterfrom
dgsudharsan:sflow_fixes
Sep 4, 2020
Merged

Sflow fixes during DEL processing#1427
prsunny merged 1 commit intosonic-net:masterfrom
dgsudharsan:sflow_fixes

Conversation

@dgsudharsan
Copy link
Collaborator

What I did
Fixed SFLOW handling in the DEL path. Below issues reported
#1012 (comment)

#1012 (comment)

Why I did it
Fixed the DEL sequence in the handling of sflow global and sflow interface all commands

How I verified it

  1. Perform config sflow interface level command
    Execute redis-cli -n 4 del "SFLOW|global"
    The above command should remove the local level entry along with global entries. (Earlier local interface level entries are not removed)
  2. sudo config sflow interface disable all
    redis-cli -n 4 del "SFLOW|global"
    redis-cli -n 4 del "SFLOW_SESSION|all"
    redis-cli -n 0 keys SFLOW
    (empty array)
    (Earlier the above command was listing all the entries)

Details if related

@prsunny
Copy link
Collaborator

prsunny commented Sep 4, 2020

@wendani , please review

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prsunny prsunny merged commit 65f63c1 into sonic-net:master Sep 4, 2020
abdosi pushed a commit that referenced this pull request Sep 19, 2020
Co-authored-by: dgsudharsan <sudharsan_gopalarat@dell.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…et#1427)

Refactored code in neighbor_advertiser script and used mock module to unittesting
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Update SAI submodule v1.9 with the following fixes

7594e53 (HEAD, origin/v1.9) Skip brcm teardown assertion (sonic-net#1423) (sonic-net#1428)
0c33f4a [FIX]Fix the circular reference issue when build sai header py (sonic-net#1427)
7e0fc24 Add support for building under Doxygen 1.9.1 (sonic-net#1414) (sonic-net#1424)
8ecf3ef [Fix]Correct enum check on branch 1.9 (sonic-net#1418)
e2b2f39 Add Thrift 0.14.1 compatibility (sonic-net#1403) (sonic-net#1416)
@dgsudharsan dgsudharsan deleted the sflow_fixes branch March 9, 2023 02:00
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
Co-authored-by: dgsudharsan <sudharsan_gopalarat@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants