[tests/conftest.py]: new API runcmd_interactive.#1424
Open
praveen-li wants to merge 1 commit intosonic-net:masterfrom
Open
[tests/conftest.py]: new API runcmd_interactive.#1424praveen-li wants to merge 1 commit intosonic-net:masterfrom
praveen-li wants to merge 1 commit intosonic-net:masterfrom
Conversation
Member
Author
|
retest vs please |
Changes: -- new API runcmd_interactive to execute a command in interactive mode. Usage: Say in a Test, we want to run "config save" and want to pass confirmation later. Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
0a16350 to
11f01f7
Compare
Member
Author
|
@lguohan kindly review. This API to run command in interactive mode will be useful for tests. Thx. -- new API runcmd_interactive to execute a command in interactive mode. |
Member
Author
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1424 in repo Azure/sonic-swss |
Member
Author
|
@jleveque : How can I run only 'Azure.sonic-swss'. thx |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Update SAI submodule v1.9 with the following fixes 7594e53 (HEAD, origin/v1.9) Skip brcm teardown assertion (sonic-net#1423) (sonic-net#1428) 0c33f4a [FIX]Fix the circular reference issue when build sai header py (sonic-net#1427) 7e0fc24 Add support for building under Doxygen 1.9.1 (sonic-net#1414) (sonic-net#1424) 8ecf3ef [Fix]Correct enum check on branch 1.9 (sonic-net#1418) e2b2f39 Add Thrift 0.14.1 compatibility (sonic-net#1403) (sonic-net#1416)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
-- new API runcmd_interactive to execute a command in interactive mode.
Usage: Say in a Test, we want to run "config save" and want to pass
confirmation later.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
What I did
Changes:
-- new API runcmd_interactive to execute a command in interactive mode.
Usage: Say in a Test, we want to run "config save" and want to pass
confirmation later.
Why I did it
Need such command for tests like below:
How I verified it
Wrote test which uses it, for lock in configDB. These tests are not pushed in Azure but we need interactive command to run better tests anyways.
Details if related