Skip to content

[201911] Fixes for NAT lgtm alerts #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlhui merged 1 commit into from
Dec 16, 2020
Merged

[201911] Fixes for NAT lgtm alerts #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cfgmgr/natmgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4113,7 +4113,7 @@ void NatMgr::setDynamicAllForwardOrAclbasedRules(const string &opCmd, const stri
/* After deletion, set acl_interface to None */
if (opCmd == DELETE)
{
m_natBindingInfo[dynamicKey].acl_interface == NONE_STRING;
m_natBindingInfo[dynamicKey].acl_interface = NONE_STRING;
}
}

Expand Down
8 changes: 8 additions & 0 deletions natsyncd/natsync.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ NatSync::NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *
}
}

NatSync::~NatSync()
{
if (m_AppRestartAssist)
{
delete m_AppRestartAssist;
}
}

/* To check the port init is done or not */
bool NatSync::isPortInitDone(DBConnector *app_db)
{
Expand Down
1 change: 1 addition & 0 deletions natsyncd/natsync.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class NatSync : public NetMsg
{
public:
NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *stateDb, NfNetlink *nfnl);
~NatSync();

virtual void onMsg(int nlmsg_type, struct nl_object *obj);

Expand Down