[201911] Fixes for NAT lgtm alerts#1391
Merged
rlhui merged 1 commit intosonic-net:201911from Dec 16, 2020
Merged
Conversation
Signed-off-by: Akhilesh Samineni <[email protected]>
Contributor
Author
|
@abdosi Could you please merge this PR. |
Contributor
Author
|
@abdosi LGTM always fails on 201911 branch as we known with below errors [2020-08-10 05:59:53] [build] fpmsyncd.cpp:3:10: fatal error: logger.h: No such file or directory |
Contributor
Author
Contributor
Author
|
Retest this please. |
Contributor
|
This PR is similar as #1320 which is merged on master branch. Signed-off-by: Akhilesh Samineni [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar as #1320 which is merged on master branch.
Signed-off-by: Akhilesh Samineni [email protected]