Revert "orchagent: Updating the route next hop ID also sets action to forward"#138
Merged
Revert "orchagent: Updating the route next hop ID also sets action to forward"#138
Conversation
qiluo-msft
approved these changes
Nov 17, 2016
stcheng
pushed a commit
that referenced
this pull request
Nov 17, 2016
… forward" (#138) This change breaks the latest test as the current SAI implementation doesn't support the mid-state that the route with packet action DROP is set with next hop ID and packet action FORWARD by two steps. The implementation also prevents removing the default route and create a new route instead. After the SAI implementation is fixed, this change will be re-introduced. ref: opencomputeproject/SAI#253
andriymoroz-mlnx
pushed a commit
to andriymoroz-mlnx/sonic-swss
that referenced
this pull request
Dec 6, 2016
… forward" (sonic-net#138) This change breaks the latest test as the current SAI implementation doesn't support the mid-state that the route with packet action DROP is set with next hop ID and packet action FORWARD by two steps. The implementation also prevents removing the default route and create a new route instead. After the SAI implementation is fixed, this change will be re-introduced. ref: opencomputeproject/SAI#253
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Dec 19, 2016
…ction to forward" (sonic-net#138)" This reverts commit 05bac48.
stcheng
pushed a commit
that referenced
this pull request
Jan 11, 2017
…#145) * Enables commit "orchagent: Updating the route next hop ID also sets action to forward" (#138)" This reverts commit 05bac48. * Change route attribute order during route modification. Based on Mellanox SAI implementation to change route action from drop to forward packet action attribute should be set before next hop.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Oct 6, 2025
**What I did** - Added neighbor_miss trap type support - enum capability query for hostif trap type in copporch.cpp - Added hw_status field to COPP_TRAP_TABLE table in state_db **Why I did it** HLD: [sonic-net/SONiC#1943](sonic-net/SONiC#1943) **How I verified it** Verified with test_copp.py DVS test Verified on Sonic switch with and without neighbor_miss trap support by vendorSAI. **Details if related** PR Dependencies: - Depends on: sonic-net/sonic-swss-common#1010 - Depends on: sonic-net/sonic-sairedis#1586 Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
Add queue oid to port oid map name Add queue oid to queue index map name Signed-off-by: marian-pritsak <marianp@mellanox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #136
This change breaks the test as the current SAI implementation doesn't support the mid-state that the route with packet action DROP is set with next hop ID and packet action FORWARD by two steps. After the SAI implementation is fixed, this change will be re-introduced.