[portsorch] add buffer drop FC group#1368
Merged
daall merged 1 commit intosonic-net:masterfrom Aug 20, 2020
Merged
Conversation
Signed-off-by: Mykola Faryma <[email protected]>
3 tasks
daall
reviewed
Jul 31, 2020
Contributor
daall
left a comment
daall
left a comment
There was a problem hiding this comment.
LGTM, will wait on SAI updates/draft status to approve. Thank you! :)
Contributor
|
retest vs please |
daall
approved these changes
Aug 20, 2020
Contributor
|
@mykolaf I also missed until I took a closer look at the 201911 PR: I think "PORT_BUFFER_DROP" in FlexCounterOrch should refer to PORT_BUFFER_DROP_STAT_FLEX_COUNTER_GROUP instead of PORT_STAT_COUNTER_FLEX_COUNTER_GROUP. It doesn't look like it effects the behavior, but we should probably fix it to be consistent. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…onic-net#1368) * Skip records of FDB entries, which are linked to default Vlan 1, to prevent exception throwing while performing command 'show mac' or 'fdbshow'. Signed-off-by: Maksym Belei <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Mykola Faryma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma [email protected]
Do not merge yet, as this also needs a SAI impl update
What I did
Introduce separate FC group for port level buffer drop counters as discussed in Azure#1308
Why I did it
How I verified it
Details if related