Skip to content

[port_buffer_drop] Add Port buffer drop counters in SONiC doc#658

Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom
mykolaf:port_buff_drop
Oct 13, 2020
Merged

[port_buffer_drop] Add Port buffer drop counters in SONiC doc#658
liat-grozovik merged 2 commits intosonic-net:masterfrom
mykolaf:port_buff_drop

Conversation

@mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Aug 7, 2020

Add req doc for sonic-net/sonic-swss#1368 as the community requested

Signed-off-by: Mykola Faryma [email protected]

@mykolaf mykolaf requested a review from liat-grozovik August 7, 2020 13:12
## 2.1 Functional Requirements
1. New flex counter group is introduced for the port-level buffer drop counters
2. The FC group is enabled by default
3. The polling interval is 60s by defaul
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s defaul default

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

-------------------------- ------------------ --------
QUEUE_STAT default (10000) enable
PORT_STAT default (1000) enable
PORT_BUFFER_DROP default (60000) enable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to mark the added one comparing to the current implementation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

### 3.1.3 Setting new polling interval
```
admin@sonic:~$ counterpoll port-buffer-drop interval 30000
``` No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have schema update, right? please add it to the design.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port buffer drop counters does not introduce any new schema.

Signed-off-by: Mykola Faryma <[email protected]>
@liat-grozovik liat-grozovik merged commit aaedc4a into sonic-net:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants