Swss.common.multi.consumer

common/consumertable.cpp

@@ -37,7 +37,10 @@ ConsumerTable::ConsumerTable(DBConnector *db, string tableName) :
         }
         catch (...)
         {
-            delete m_subscribe;
+            if(m_subscribe) {
+                delete m_subscribe;
+                m_subscribe = NULL;
+            }            
         }
     }
 
@@ -47,7 +50,9 @@ ConsumerTable::ConsumerTable(DBConnector *db, string tableName) :
 
 ConsumerTable::~ConsumerTable()
 {
-    delete m_subscribe;
+    if(m_subscribe) {
+        delete m_subscribe;
+    }
 }
 
 static string pop_front(queue<RedisReply *> &q)

common/scheme.h

@@ -1,17 +1,32 @@
 #ifndef __SCHEME__
 #define __SCHEME__
 
+
+#define _in_
+#define _out_
+#define _inout_
+
 namespace swss {
 
 #define APPL_DB         0
 #define ASIC_DB         1
 
-#define APP_PORT_TABLE_NAME     "PORT_TABLE"
-#define APP_VLAN_TABLE_NAME     "VLAN_TABLE"
-#define APP_LAG_TABLE_NAME      "LAG_TABLE"
-#define APP_INTF_TABLE_NAME     "INTF_TABLE"
-#define APP_NEIGH_TABLE_NAME    "NEIGH_TABLE"
-#define APP_ROUTE_TABLE_NAME    "ROUTE_TABLE"
+#define APP_PORT_TABLE_NAME             "PORT_TABLE"
+#define APP_VLAN_TABLE_NAME             "VLAN_TABLE"
+#define APP_LAG_TABLE_NAME              "LAG_TABLE"
+#define APP_INTF_TABLE_NAME             "INTF_TABLE"
+#define APP_NEIGH_TABLE_NAME            "NEIGH_TABLE"
+#define APP_ROUTE_TABLE_NAME            "ROUTE_TABLE"
+
+#define APP_TC_TO_QUEUE_MAP_TABLE_NAME  "TC_TO_QUEUE_MAP_TABLE"
+#define APP_SCHEDULER_TABLE_NAME        "SCHEDULER_TABLE"
+#define APP_DSCP_TO_TC_MAP_TABLE_NAME   "DSCP_TO_TC_MAP_TABLE"
+#define APP_QUEUE_TABLE_NAME            "QUEUE_TABLE"
+#define APP_PORT_QOS_MAP_TABLE_NAME     "PORT_QOS_MAP_TABLE"
+#define APP_WRED_PROFILE_TABLE_NAME     "WRED_PROFILE_TABLE"
+
+
+
 
 #define IPV4_NAME "IPv4"
 #define IPV6_NAME "IPv6"

common/select.cpp

@@ -1,4 +1,6 @@
+#include <algorithm>
 #include "common/selectable.h"
+#include "common/logger.h"
 #include "common/select.h"
 #include <stdio.h>
 #include <sys/time.h>
@@ -8,17 +10,28 @@ using namespace std;
 
 namespace swss {
 
-void Select::addSelectable(Selectable *c)
+void Select::addSelectable(_in_ Selectable *selectable)
 {
-    m_objects.push_back(c);
+    if(std::find(m_objects.begin(), m_objects.end(), selectable) != m_objects.end()) {
+        SWSS_LOG_WARN("Selectable:%p already been added to the list, ignoring\n.");
+        return;
+    }
+    m_objects.push_back(selectable);
+}
+
+void Select::addSelectables(_in_ std::vector<Selectable *> &selectables)
+{
+    for(auto it : selectables) {
+        addSelectable(it);
+    }    
 }
 
 void Select::addFd(int fd)
 {
     m_fds.push_back(fd);
 }
 
-int Select::select(Selectable **c, int *fd, unsigned int timeout)
+int Select::select(_out_ Selectable **c, _out_ int *fd, _in_ unsigned int timeout)
 {
     struct timeval t = {0, (suseconds_t)(timeout)*1000};
     struct timeval *pTimeout = NULL;

common/select.h

@@ -7,13 +7,15 @@
 #include <hiredis/hiredis.h>
 #include "selectable.h"
 
+
 namespace swss {
 
 class Select
 {
 public:
     /* Add object for select */
-    void addSelectable(Selectable *c);
+    void addSelectables(_in_ std::vector<Selectable *> &selectables);
+    void addSelectable(_in_ Selectable *selectable);
 
     /* Add file-descriptor for select  */
     void addFd(int fd);
@@ -28,8 +30,7 @@ class Select
         ERROR = 2,
         TIMEOUT = 3
     };
-    int select(Selectable **c, int *fd,
-               unsigned int timeout = std::numeric_limits<unsigned int>::max());
+    int select(_out_ Selectable **c, _out_ int *fd, _in_ unsigned int timeout = std::numeric_limits<unsigned int>::max());
 
 private:
     /* Create a new redisContext, SELECT DB and SUBSRIBE */

common/table.h

@@ -38,11 +38,11 @@ class Table {
     void delField(std::string key, std::string field);
 
     virtual ~Table();
+    std::string getTableName()const {return m_tableName;};
 
 protected:
     /* Return the actual key name as a comibation of tableName:key */
     std::string getKeyName(std::string key);
-
     std::string getKeyQueueTableName();
     std::string getValueQueueTableName();
     std::string getOpQueueTableName();