Closed
Conversation
* Select accepts multiple Consumers at once * Added defines for QOS tables
hrachya-m
force-pushed
the
swss.common.multi.consumer
branch
from
9362a46 to
fb3bc8e
Compare
Contributor
| { | ||
| m_objects.push_back(c); | ||
| if(std::find(m_objects.begin(), m_objects.end(), selectable) != m_objects.end()) { | ||
| SWSS_LOG_WARN("Selectable:%p already been added to the list, ignoring\n."); |
Contributor
There was a problem hiding this comment.
"\n." is not needed, we can enforce in logs to add \n at the end but currently it goes to syslog so no need,
also yuo forgot to add "selectable" as parameter since you using %p
Contributor
|
In general, you should break this commit to 3 differet commits. There are too many logical changes here. |
common/consumertable.cpp
Outdated
| delete m_subscribe; | ||
| if(m_subscribe) { | ||
| delete m_subscribe; | ||
| m_subscribe = NULL; |
Contributor
There was a problem hiding this comment.
There is no needed to "if (m_subscribe)", it's ok to delete NULL.
As for "m_subscribe = NULL;" it's a good change.
added 2 commits
April 13, 2016 17:21
* remove empty lines * moved Table::getTableName from .h into .cpp * removed new table name declarations, will put into different commit. Signed-off-by: Hrachya Mughnetsyan [email protected]
* added declarations of QOS related table names Signed-off-by: Hrachya Mughnetsyan [email protected]
hrachya-m
pushed a commit
to hrachya-m/sonic-swss-common
that referenced
this pull request
Apr 15, 2016
* follow up comments from sonic-net#4 * removed qos related defines * removed in out defines Signed-off-by: Hrachya Mughnetsyan [email protected]
Contributor
|
thanks |
kcudnik
pushed a commit
that referenced
this pull request
May 12, 2016
* [Select, Table] Changes to enable multiple consumers in Orch * Select accepts multiple Consumers at once * Added defines for QOS tables * [common] follow-up [1] on pull request comments * remove empty lines * moved Table::getTableName from .h into .cpp * removed new table name declarations, will put into different commit. Signed-off-by: Hrachya Mughnetsyan [email protected] * [common] follow-up [2] on pull request comments * added declarations of QOS related table names Signed-off-by: Hrachya Mughnetsyan [email protected] * [commoon] changes to enable multiple consumers on Orch, * follow up comments from #4 * removed qos related defines * removed in out defines Signed-off-by: Hrachya Mughnetsyan [email protected] * [common] warn message fix * added missing parameter to trace message * removed std:: prefix from function call * [common] removed std:: prefixes * remvoed std:: prefixes Signed-off-by: [email protected] * swss-common: Add qos table names * Added QOS table names Signed-off-by: [email protected] * [swss-common] Add buffer table names * New table names for buffer component Signed-off-by: [email protected]
zbud-msft
pushed a commit
to zbud-msft/sonic-swss-common
that referenced
this pull request
Aug 3, 2022
Facilitate C-binding for Go
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
…onic-net#4) With adding more columns into the port_config.ini file, the previous logic of checking len(line.split()) == 4 is no longer valid. With adding the logic of parsing the title of the file, the port index could be directly retrieved depending on which column it is. Signed-off-by: Shu0T1an ChenG <[email protected]>
Pterosaur
pushed a commit
to Pterosaur/sonic-swss-common
that referenced
this pull request
Apr 13, 2025
Implementing following CVL APIs : SortDepTables GetOrderedTables GetDepTables GetDepDataForDelete GetValidationTimeStats ClearValidationTimeStats
nazariig
referenced
this pull request
in nazariig/sonic-swss-common
May 6, 2025
```<br>* bbd09cc - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-swss-common into 202412 (2025-02-11) [Sonic Automation] * 8f47a37 - (origin/202411) Handle 'bulkget' in consumer_table_pops.lua (sonic-net#970) (2025-02-07) [mssonicbld]<br>```
blorente
added a commit
to blorente/sonic-swss-common
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.