Remove gbsyncd_start.sh#808
Merged
jleveque merged 1 commit intosonic-net:masterfrom Mar 22, 2021
jleveque:remove_gbsyncd_start_sh
Merged
Remove gbsyncd_start.sh#808jleveque merged 1 commit intosonic-net:masterfrom jleveque:remove_gbsyncd_start_sh
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:remove_gbsyncd_start_sh
Conversation
lguohan
approved these changes
Mar 22, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
`gbsyncd_start.sh` was a simple wrapper which only called `exec "/usr/bin/gbsyncd_startup.py"`. This causes unnecessary extra complexity and maintenance. It makes things simpler to run `/usr/bin/gbsyncd_startup.py` directly, which is being done by sonic-net/sonic-buildimage#7084. That PR has merged, so we can now merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gbsyncd_start.shwas a simple wrapper which only calledexec "/usr/bin/gbsyncd_startup.py". This causes unnecessary extra complexity and maintenance. It makes things simpler to run/usr/bin/gbsyncd_startup.pydirectly, which is being done by sonic-net/sonic-buildimage#7084. That PR has merged, so we can now merge this.