[docker-gbsyncd-vs] Run gbsyncd_startup.py directly#7084
Merged
jleveque merged 1 commit intosonic-net:masterfrom Mar 19, 2021
jleveque:gbsyncd_cleanup
Merged
[docker-gbsyncd-vs] Run gbsyncd_startup.py directly#7084jleveque merged 1 commit intosonic-net:masterfrom jleveque:gbsyncd_cleanup
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:gbsyncd_cleanup
Conversation
Contributor
Author
|
@sydlogan: Please review. |
lguohan
approved these changes
Mar 19, 2021
jleveque
added a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Mar 22, 2021
`gbsyncd_start.sh` was a simple wrapper which only called `exec "/usr/bin/gbsyncd_startup.py"`. This causes unnecessary extra complexity and maintenance. It makes things simpler to run `/usr/bin/gbsyncd_startup.py` directly, which is being done by sonic-net/sonic-buildimage#7084. That PR has merged, so we can now merge this.
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
Eliminate the need for `gbsyncd_start.sh`, which simply calls `exec "/usr/bin/gbsyncd_startup.py"`. The shell script is unnecessary. Once this PR merges, we can remove `gbsyncd_start.sh` from the sonic-sairedis repo.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Eliminate the need for `gbsyncd_start.sh`, which simply calls `exec "/usr/bin/gbsyncd_startup.py"`. The shell script is unnecessary. Once this PR merges, we can remove `gbsyncd_start.sh` from the sonic-sairedis repo.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Eliminate the need for `gbsyncd_start.sh`, which simply calls `exec "/usr/bin/gbsyncd_startup.py"`. The shell script is unnecessary. Once this PR merges, we can remove `gbsyncd_start.sh` from the sonic-sairedis repo.
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
`gbsyncd_start.sh` was a simple wrapper which only called `exec "/usr/bin/gbsyncd_startup.py"`. This causes unnecessary extra complexity and maintenance. It makes things simpler to run `/usr/bin/gbsyncd_startup.py` directly, which is being done by sonic-net/sonic-buildimage#7084. That PR has merged, so we can now merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Eliminate the need for
gbsyncd_start.sh, which simply callsexec "/usr/bin/gbsyncd_startup.py". The shell script is unnecessary.Once this PR merges, we can remove
gbsyncd_start.shfrom the sonic-sairedis repo.Which release branch to backport (provide reason below if selected)