Skip to content

[fabric] Extend supported counter list in syncd's FlexCounter for fabric#669

Merged
lguohan merged 1 commit intosonic-net:masterfrom
ngoc-do:fabric
Oct 12, 2020
Merged

[fabric] Extend supported counter list in syncd's FlexCounter for fabric#669
lguohan merged 1 commit intosonic-net:masterfrom
ngoc-do:fabric

Conversation

@ngoc-do
Copy link
Contributor

@ngoc-do ngoc-do commented Oct 7, 2020

New SAI version provides more counters for fabric ports. Extend the supported counter list to cover those counters.

/** SAI port stat if in FEC correctable pkts */
SAI_PORT_STAT_IF_IN_FEC_CORRECTABLE_FRAMES,

/** SAI port stat if in FEC not correctable pkts */
SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES,

/** SAI port stat if in FEC symbol errors */
SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS,

/** Fabric port stat in data units */
SAI_PORT_STAT_IF_IN_FABRIC_DATA_UNITS,

/** Fabric port stat out data units */
SAI_PORT_STAT_IF_OUT_FABRIC_DATA_UNITS,

/** Port stat in drop reasons range start */
SAI_PORT_STAT_IN_DROP_REASON_RANGE_BASE = 0x00001000,

Signed-off-by: ngocdo [email protected]

@lguohan lguohan requested a review from kcudnik October 8, 2020 13:34
@kcudnik
Copy link
Collaborator

kcudnik commented Oct 8, 2020

to have this always up to date even if SAI add new counters, we could use already generated metadata for sai_port_stat_t enum, and only use enums that value is less than SAI_PORT_STAT_IN_DROP_REASON_RANGE_BASE, then we actually include all enums, even if new added
@lguohan also just wondering why we don't include in/out configured drop reasons stats here ?

@lguohan
Copy link
Contributor

lguohan commented Oct 12, 2020

@daall to check out if there is any harm to do that, i think debug counters need to be configured.

@lguohan lguohan merged commit 0f3668f into sonic-net:master Oct 12, 2020
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
New SAI version provides more counters for fabric ports. Extend the supported counter list to cover those counters.

    /** SAI port stat if in FEC correctable pkts */
    SAI_PORT_STAT_IF_IN_FEC_CORRECTABLE_FRAMES,

    /** SAI port stat if in FEC not correctable pkts */
    SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES,

    /** SAI port stat if in FEC symbol errors */
    SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS,

    /** Fabric port stat in data units */
    SAI_PORT_STAT_IF_IN_FABRIC_DATA_UNITS,

    /** Fabric port stat out data units */
    SAI_PORT_STAT_IF_OUT_FABRIC_DATA_UNITS,

    /** Port stat in drop reasons range start */
    SAI_PORT_STAT_IN_DROP_REASON_RANGE_BASE = 0x00001000,

Signed-off-by: ngocdo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants