[202505] Fix error handling logic in sairedis#1717
Open
prabhataravind wants to merge 4 commits intosonic-net:202505from
Open
[202505] Fix error handling logic in sairedis#1717prabhataravind wants to merge 4 commits intosonic-net:202505from
prabhataravind wants to merge 4 commits intosonic-net:202505from
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/202505_oa_crash_handling
branch
from
bfde167 to
6e5effe
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/202505_oa_crash_handling
branch
from
6e5effe to
269590e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
prabhataravind
force-pushed
the
paravind/202505_oa_crash_handling
branch
from
269590e to
5eb5bba
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
changed the title
Contributor
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
approved these changes
Dec 15, 2025
Contributor
|
Hi @StormLiangMS, could you please help review this one as it is to 202505? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAI errors such as SAI_STATUS_ITEM_ALREADY_EXISTS and SAI_STATUS_ITEM_NOT_FOUND are gracefully handled in swss since PR sonic-net/sonic-swss#3706. There is no need to explicitly throw an exception in sairedis as well when such errors are encountered.
Master PR: #1716