Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference.#1324
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Nov 21, 2023
Merged
Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference.#1324kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Ashish1805
commented
Nov 20, 2023
Ashish1805
commented
- In PR [Link Event Damping] Port state change handler class #1310, a constexpt static data member was added. Since sairedis repo uses c++14, definition of this data member needs to be provided in .cpp file too.
reference. - In PR sonic-net#1310, a constexpt static data member was added. Since sairedis repo uses c++14, definition of this data member needs to be provided in .cpp file too.
Contributor
Author
|
@kcudnik I think there is some issue in |
prsunny
approved these changes
Nov 21, 2023
Contributor
|
@kcudnik , we may want to force-merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.