[Link Event Damping] Port state change handler class#1310
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Nov 16, 2023
Merged
[Link Event Damping] Port state change handler class#1310kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
could you give more meaningful title and description ? |
Ashish1805
force-pushed
the
ledamping_1
branch
2 times, most recently
from
26ffcca to
3d91513
Compare
Ashish1805
force-pushed
the
ledamping_1
branch
from
3d91513 to
db4195b
Compare
Ashish1805
changed the title
Contributor
Author
Changed the title and description. Thank you. |
Contributor
Author
|
Adding @Junchao-Mellanox for review. |
kcudnik
reviewed
Oct 31, 2023
kcudnik
reviewed
Oct 31, 2023
kcudnik
reviewed
Oct 31, 2023
Ashish1805
force-pushed
the
ledamping_1
branch
from
db4195b to
53090e4
Compare
Junchao-Mellanox
approved these changes
Nov 8, 2023
kcudnik
approved these changes
Nov 8, 2023
Contributor
Author
|
Hi @kcudnik , I dont have permission to merge PRs. Can you please merge this PR? Thank you. |
Ashish1805
force-pushed
the
ledamping_1
branch
from
845bae8 to
e944019
Compare
- Class to handle the port state change event callback from SAI and sending the events to syncd main thread for processing by link event damper. Depends on: sonic-net#1297 HLD: sonic-net/SONiC#1071
Ashish1805
force-pushed
the
ledamping_1
branch
from
e944019 to
a3177df
Compare
Collaborator
|
is this ready to merge ? |
Contributor
Author
Yes, it is ready for merge. Thanks. |
Collaborator
|
@Ashish1805 your change caused compilation issues on swss, please fix this right away or this change will be reverted: https://github.com/sonic-net/sonic-swss/actions/runs/6910957833/job/18804862990?pr=2902 |
Collaborator
|
change to first keyword static requires declaration in cpp file since it's considered a field |
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 20, 2023
reference. - In PR sonic-net#1310, a constexpt static data member was added. Since sairedis repo uses c++14, definition of this data member needs to be provided in .cpp file too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class to handle the port state change event callback from SAI and sending the link events to syncd main thread for processing by link event damper.
HLD: sonic-net/SONiC#1071