validation support for SAI_ATTR_VALUE_TYPE_JSON#1152
Merged
prsunny merged 7 commits intosonic-net:masterfrom Nov 29, 2022
svshah-intel:master
Merged
validation support for SAI_ATTR_VALUE_TYPE_JSON#1152prsunny merged 7 commits intosonic-net:masterfrom svshah-intel:master
prsunny merged 7 commits intosonic-net:masterfrom
svshah-intel:master
Conversation
Contributor
|
LGTM, but please resolve the check for Pull Request Coverage |
Contributor
Author
Thank you for the review. Any suggestion to get past that? May be there is a way to handle this within sonic-sairedis repo? I may need a pointer where to add this attr value type then to handle coverage. |
|
@kcudnik would you please help to review this PR? Thanks. |
kcudnik
previously approved these changes
Nov 16, 2022
Contributor
Author
|
@kcudnik , @richardyu-ms please review updated diffs. I've added unittests for code coverage. Now codecoverage is 100%. |
svshah-intel
requested review from
kcudnik
and removed request for
richardyu-ms
richardyu-ms
approved these changes
Nov 18, 2022
8 tasks
prsunny
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 1, 2022
…attr value sairedis commits: b1e9c91 2022-11-29 | validation support for SAI_ATTR_VALUE_TYPE_JSON (sonic-net/sonic-sairedis#1152)
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
* validation support for SAI_ATTR_VALUE_TYPE_JSON * add sairedis-lib and vslib tests for generic programmable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a support added for attr value type json, there is a validation support for this attr value type missing. This PR is to enable validation checks for the same.
Signed-off-by: svshah-intel [email protected]