[xcvrd] Extend xcvrd with SFP error event handling#52
Merged
jleveque merged 2 commits intosonic-net:masterfrom Apr 16, 2020
Merged
[xcvrd] Extend xcvrd with SFP error event handling#52jleveque merged 2 commits intosonic-net:masterfrom
jleveque merged 2 commits intosonic-net:masterfrom
Conversation
jleveque
suggested changes
Apr 3, 2020
qiluo-msft
reviewed
Apr 3, 2020
…tatus using enum for sfp error code
jleveque
approved these changes
Apr 14, 2020
Collaborator
Author
|
@jleveque can we merge this one and also sonic-net/sonic-platform-common#80 ? |
abdosi
pushed a commit
that referenced
this pull request
Apr 19, 2020
* extend xcvrd with SFP error event handling * change sfp error table to status table, store plug in/out and error status using enum for sfp error code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SFP event handling logic to XCVRD, the main purpose is to stop accessing SFP EEPROM when some error event raised from SFP and which will block the EEPROM accessing. Design refer to sonic-net/SONiC#586
When receive the error event on some SFP, the related ports will be added to a new table which is to store the ports that on top of the error SFP, xcvrd will remove the DOM table and stop to update the DOM until SFP recovered from the error. This is done by checking the new table before reading the DOM, if ports in error status, DOM update will be skipped.
A plug in event received on the error SFP will be considered as this SFP is recovered from error status.
This PR has a dependency on sonic-net/sonic-buildimage#4365 and sonic-net/sonic-platform-common#80