[xcvrd HLD] Update xcvrd HLD doc#586
Merged
liat-grozovik merged 15 commits intomasterfrom Jun 15, 2021
Merged
Conversation
1. Reflect the current implementation of xcvrd to the HLD. 2. Add new SFP error event handling procedure.
jleveque
suggested changes
Apr 3, 2020
qiluo-msft
reviewed
Apr 3, 2020
address review comments
lguohan
reviewed
Apr 29, 2020
describe sfp error in a bitmap way
jleveque
suggested changes
Apr 9, 2021
jleveque
suggested changes
Apr 29, 2021
Collaborator
|
@qiluo-msft kindly reminder. can you please check recent changes so we can merge? |
qiluo-msft
reviewed
May 17, 2021
qiluo-msft
reviewed
May 17, 2021
4 tasks
qiluo-msft
approved these changes
May 25, 2021
jleveque
approved these changes
May 25, 2021
- API get_change_event returns error description for vendor specific errors xcvrd will call get_error_description if there is an error without description - The CLI fetch error status from STATE_DB by default Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Adjust the HLD for error status
jleveque
suggested changes
Jun 2, 2021
qiluo-msft
reviewed
Jun 3, 2021
Signed-off-by: Stephen Sun <[email protected]>
Update xcvrd HLD: Fix review comments
Co-authored-by: Qi Luo <[email protected]>
qiluo-msft
approved these changes
Jun 8, 2021
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Please also check with other reviewers.
Collaborator
|
@Junchao-Mellanox @keboliu can you please add the PRs of the enhancement to this HLD for tracking? |
Collaborator
Author
done. |
jleveque
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: