Skip to content

[python coverage]fix result color bar#196

Merged
lguohan merged 3 commits intosonic-net:masterfrom
pettershao-ragilenetworks:fix_python_coverage_color_bar
Jul 8, 2021
Merged

[python coverage]fix result color bar#196
lguohan merged 3 commits intosonic-net:masterfrom
pettershao-ragilenetworks:fix_python_coverage_color_bar

Conversation

@pettershao-ragilenetworks
Copy link
Copy Markdown
Contributor

What I did
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report"
more info check: sonic-net/sonic-snmpagent#215
How I did it
install dotnet core
How to verify it

Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
@pettershao-ragilenetworks
Copy link
Copy Markdown
Contributor Author

@xumia @lguohan hi , help forward, thanks!

@lguohan lguohan merged commit 3df6757 into sonic-net:master Jul 8, 2021
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 15, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
judyjoseph pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 7, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
To include:
> 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) 
> 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
In midplane API, default method should be raise NotImplementedError not return NotImplementedError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants