Install dotnet core to fix python gcov warning for code covery color bar showing by pettershao-ragilenetworks · Pull Request #215 · sonic-net/sonic-snmpagent

pettershao-ragilenetworks · 2021-05-06T07:47:07Z

- What I did
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report"
- How I did it
install dotnet core
- How to verify it

- Description for the changelog

Install .NET CORE

…enetworks-install-dotnet-core install dotnet core

pettershao-ragilenetworks · 2021-05-07T00:39:59Z

@lguohan report is now coveried by red & green bar, help review, then i will try to fix all other python components. check pipeline: https://dev.azure.com/mssonic/build/_build/results?buildId=13993&view=codecoverage-tab

xumia · 2021-05-10T08:50:25Z

azure-pipelines.yml

+        sudo apt-get install -y apt-transport-https
+        sudo apt-get update
+        sudo apt-get install -y dotnet-sdk-5.0
      displayName: "Unit tests"


It is better to create a new step to install the .net core, not in the "Unit tests" step.
Looks like we can remove the Line 66.

pettershao-ragilenetworks · 2021-05-11T01:46:00Z

ok, done! @xumia help forward!

pettershao-ragilenetworks · 2021-05-20T03:36:41Z

hi @xumia help forward!

trigger build

qiluo-msft · 2021-06-10T05:17:12Z

azure-pipelines.yml

+        sudo apt-get install -y apt-transport-https
+        sudo apt-get update
+        sudo apt-get install -y dotnet-sdk-5.0
+      displayName: "Install publish Dependencies"


publish

Is it a typo? Do you mean "Install .NET CORE" ? #Closed

qiluo-msft · 2021-06-10T05:17:34Z

azure-pipelines.yml

+        wget https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb -O packages-microsoft-prod.deb
+        sudo dpkg -i packages-microsoft-prod.deb
+        sudo apt-get update
+        sudo apt --fix-broken install -y


broken

What is broken and why? #Closed

also for directlly install dot sdk:
https://dev.azure.com/mssonic/build/_build/results?buildId=19148&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96

You might want to run 'apt --fix-broken install' to correct these. The following packages have unmet dependencies: dotnet-sdk-5.0 : Depends: dotnet-runtime-5.0 (>= 5.0.7) but it is not going to be installed Depends: netstandard-targeting-pack-2.1 (>= 2.1.0) but it is not going to be installed Depends: aspnetcore-runtime-5.0 (>= 5.0.7) but it is not going to be installed Depends: dotnet-targeting-pack-5.0 (>= 5.0.0) but it is not going to be installed Depends: aspnetcore-targeting-pack-5.0 (>= 5.0.0) but it is not going to be installed Depends: dotnet-apphost-pack-5.0 (>= 5.0.7) but it is not going to be installed libhiredis-dev : Depends: libhiredis0.14 (= 0.14.0-3) but 0.14.0-3~bpo9+1 is to be installed libnl-3-dev : Depends: libnl-3-200 (= 3.4.0-1) but 3.5.0-1 is to be installed libnl-route-3-dev : Depends: libnl-route-3-200 (= 3.4.0-1) but 3.5.0-1 is to be installed E: Unmet dependencies. Try 'apt --fix-broken install' with no packages (or specify a solution).

It should be caused by wrong package packages-microsoft-prod installed, the script is run inside the container, so we need to install the package for debian buster, not ubuntu 20.04.
Please follow https://docs.microsoft.com/en-us/dotnet/core/install/linux-debian, and try again, thanks.

qiluo-msft · 2021-06-10T05:18:41Z

azure-pipelines.yml

+        sudo dpkg -i packages-microsoft-prod.deb
+        sudo apt-get update
+        sudo apt --fix-broken install -y
+        sudo apt-get install -y apt-transport-https


apt-transport-https

Why you need this? #Closed

ok, seems no use, removed!

qiluo-msft · 2021-06-10T05:19:07Z

azure-pipelines.yml

+        sudo apt-get update
+        sudo apt --fix-broken install -y
+        sudo apt-get install -y apt-transport-https
+        sudo apt-get update


update

Why update twice? #Closed

pettershao-ragilenetworks · 2021-06-15T00:25:38Z

@qiluo-msft hi, help forward this, thanks!

qiluo-msft

LGTM. Please also check with other reviewers.

qiluo-msft · 2021-06-29T01:57:15Z

azure-pipelines.yml

+        curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
+        sudo apt-add-repository https://packages.microsoft.com/debian/10/prod
+        sudo apt-get update
+        sudo apt-get -y install -f


sudo apt-get -y install -f

Is this line really needed? #Closed

From test result, 'sudo apt-get -y install -f' can and only can be set at this place.

I tried these commands and removed sudo apt-get -y install -f. Seems working. Could you check again?

yea，but failed again：
https://dev.azure.com/mssonic/build/_build/results?buildId=21794&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96

I compared the log with previous one, and the previous one seems suspicious

2021-06-29T03:04:13.8494132Z The following additional packages will be installed: 2021-06-29T03:04:13.8499448Z libhiredis0.14 2021-06-29T03:04:13.8986264Z The following packages will be REMOVED: 2021-06-29T03:04:13.8993644Z libibverbs-dev libnl-3-dev libnl-route-3-dev libopenmpi-dev 2021-06-29T03:04:13.9005991Z The following packages will be upgraded: 2021-06-29T03:04:13.9011224Z libhiredis0.14 2021-06-29T03:04:13.9242794Z 1 upgraded, 0 newly installed, 4 to remove and 2 not upgraded.

The new apt source messed up the local package database. So it replaced our local built libhiredis0.14. I have not experiment, but propose several options:

Do not add apt source. Download the required deb packages and sudo dpkg -i them.

Or, add the apt source at the very beginning, before installing any other deb packages.

update result, seems not work:
put add source at begin:
https://dev.azure.com/mssonic/build/_build/results?buildId=21862&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96
remove source and only wget debs:
https://dev.azure.com/mssonic/build/_build/results?buildId=21866&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96
try dotnet-install.sh, no error but no color bar:
https://dev.azure.com/mssonic/build/_build/results?buildId=21868&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=c10d5f44-55ce-55d7-7975-407ed75d9a96

qiluo-msft · 2021-07-06T08:05:49Z

The root issue is wrong packages are installed in slave docker. Please check the patch

From 71094dd101a8a4fb47f82b6d7fc175c9cbfb2791 Mon Sep 17 00:00:00 2001
From: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Tue, 6 Jul 2021 06:19:40 +0000
Subject: [PATCH] Remove vanilla packages before installing local build ones

---
 azure-pipelines.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index f9cc32c..f73a8e0 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -44,6 +44,7 @@ stages:
 
     - script: |
         set -ex
+        sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev
         sudo dpkg -i ../target/debs/buster/{libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_*.deb,libnl-genl-3-200_*.deb,libnl-nf-3-200_*.deb,libnl-route-3-200_*.deb,libhiredis0.14_*.deb}
         sudo python3 -m pip install ../target/python-wheels/swsssdk*-py3-*.whl
         sudo python3 -m pip install ../target/python-wheels/sonic_py_common-1.0-py3-none-any.whl
@@ -61,10 +62,9 @@ stages:
     - script: |
         set -ex
         # Install .NET CORE
-        wget https://packages.microsoft.com/config/debian/10/packages-microsoft-prod.deb -O packages-microsoft-prod.deb
-        sudo dpkg -i packages-microsoft-prod.deb
+        curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
+        sudo apt-add-repository https://packages.microsoft.com/debian/10/prod
         sudo apt-get update
-        sudo apt-get -y install -f
         sudo apt-get install -y dotnet-sdk-5.0
       displayName: "Install .NET CORE"

In reply to: 874551271

pettershao-ragilenetworks · 2021-07-08T03:40:01Z

@qiluo-msft right, seems fine now. help foward this!

fix python gcov warning "Please install dotnet core to enable automatic generation of Html report" more info check: sonic-net/sonic-snmpagent#215 Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>

…bar showing (sonic-net#215) **- What I did** fix python gcov warning "Please install dotnet core to enable automatic generation of Html report" **- How I did it** install dotnet core

pettershao-ragilenetworks added 8 commits May 6, 2021 15:44

Update azure-pipelines.yml

5f70d91

Install .NET CORE

Merge pull request #1 from pettershao-ragilenetworks/pettershao-ragil…

e6fcc9b

…enetworks-install-dotnet-core install dotnet core

Update azure-pipelines.yml

7e1a53b

Update azure-pipelines.yml

8850fcc

Update azure-pipelines.yml

4391376

Update azure-pipelines.yml

25135a5

Update azure-pipelines.yml

0a5fa78

Update azure-pipelines.yml

f654d2d

pettershao-ragilenetworks closed this May 6, 2021

pettershao-ragilenetworks reopened this May 6, 2021

Update azure-pipelines.yml

c2396aa

pettershao-ragilenetworks changed the title ~~install dotnet core to fix python gcov warning~~ Install dotnet core to fix python gcov warning for code covery color bar showing May 7, 2021

xumia reviewed May 10, 2021

View reviewed changes

pettershao-ragilenetworks added 2 commits May 11, 2021 09:13

Update azure-pipelines.yml

46d3402

Update azure-pipelines.yml

ed446e9

qiluo-msft force-pushed the master branch from bac8dec to 28b9dfd Compare May 18, 2021 03:50

pettershao-ragilenetworks added 2 commits June 9, 2021 08:40

Update azure-pipelines.yml

3eeac48

trigger build

trigger build

1d2bcf2

qiluo-msft reviewed Jun 10, 2021

View reviewed changes

pettershao-ragilenetworks added 3 commits June 11, 2021 15:17

Update azure-pipelines.yml

d859738

Update azure-pipelines.yml

c8effd4

Update azure-pipelines.yml

529d2bd

qiluo-msft previously approved these changes Jun 15, 2021

View reviewed changes

pettershao-ragilenetworks mentioned this pull request Jun 23, 2021

[python coverage] fix result color bar sonic-net/sonic-platform-common#202

Merged

Update azure-pipelines.yml

18f9952

pettershao-ragilenetworks dismissed qiluo-msft’s stale review via 18f9952 June 29, 2021 00:14

pettershao-ragilenetworks added 4 commits June 29, 2021 08:33

Update azure-pipelines.yml

eedd0d1

Update azure-pipelines.yml

c289a81

Update azure-pipelines.yml

6e39459

Update azure-pipelines.yml

3ee0ba4

qiluo-msft reviewed Jun 29, 2021

View reviewed changes

pettershao-ragilenetworks added 13 commits June 29, 2021 10:06

test dependence of .NET

2a0afcc

Update azure-pipelines.yml

6e6f37d

Update azure-pipelines.yml

a538bf7

Update azure-pipelines.yml

1d61102

Update azure-pipelines.yml

92ca9d0

recover update

d010818

Update azure-pipelines.yml

881f2bb

put add source at begning

9e150fd

Update azure-pipelines.yml

5cf5f03

Update azure-pipelines.yml

c1907aa

Update azure-pipelines.yml

5f0d245

try dotnet-install.sh

e6ae344

recove change

6d7d583

Update azure-pipelines.yml

d448256

qiluo-msft approved these changes Jul 8, 2021

View reviewed changes

xumia approved these changes Jul 8, 2021

View reviewed changes

qiluo-msft merged commit 7a78703 into sonic-net:master Jul 8, 2021

Conversation

pettershao-ragilenetworks commented May 6, 2021

Uh oh!

pettershao-ragilenetworks commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xumia May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks commented May 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pettershao-ragilenetworks commented May 20, 2021

Uh oh!

qiluo-msft Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xumia Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks commented Jun 15, 2021

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

pettershao-ragilenetworks Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pettershao-ragilenetworks commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

pettershao-ragilenetworks commented May 7, 2021 •

edited

Loading

xumia May 10, 2021 •

edited

Loading

pettershao-ragilenetworks commented May 11, 2021 •

edited

Loading

qiluo-msft Jun 10, 2021 •

edited

Loading

qiluo-msft Jun 10, 2021 •

edited

Loading

pettershao-ragilenetworks Jun 11, 2021 •

edited

Loading

qiluo-msft Jun 10, 2021 •

edited

Loading

qiluo-msft Jun 10, 2021 •

edited

Loading

qiluo-msft Jun 29, 2021 •

edited

Loading

pettershao-ragilenetworks Jun 30, 2021 •

edited

Loading

qiluo-msft commented Jul 6, 2021 •

edited

Loading