[action] [PR:548] Restore optoe page to default 0 for active cables#550
Merged
mssonicbld merged 1 commit intosonic-net:202411from Mar 3, 2025
Merged
Conversation
<!-- Provide a general summary of your changes in the Title above --> #### Description Restore the optoe's page to page ZERO before reading the Lower page > 127 #### Motivation and Context When the module is busy with CDB command, the optoe kernel driver at the end of user page read request, tries to restore the page to Page ZERO and if this write fails because the module could be busy with CDB command (since these modules donot support background CDB mode). Because of this when Xcvrd tries to read offset (> 127) in Lower page, since optoe does not restore the page to 0 for any Lower page access, the page read to these offset will result in wrong page to be read (because of previous page select write failure) and Xcvrd parsing fails causing crash. Now in optoe EEPROM read API we ensure to restore the Page to ZERO page if the Page select byte is non-zero #### How Has This Been Tested? TBD: 1. Test on Arista switch 2. Test on Cisco switch #### Additional Information (Optional)
Collaborator
Author
|
Original PR: #548 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Mar 20, 2025
… 202412 (sonic-net#48) ```<br>* 63a147f - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-04) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Mar 20, 2025
… 202412 (sonic-net#50) ```<br>* f93b69c - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-05) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#52) ```<br>* b9e46c7 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-06) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#54) ```<br>* ca4e2cc - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-07) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#56) ```<br>* 8aa4a87 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-08) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#58) ```<br>* bb1a990 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-09) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#60) ```<br>* 496dbd8 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-10) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#62) ```<br>* 106e17f - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-11) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#64) ```<br>* c64e7e8 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-12) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#66) ```<br>* 6b86a59 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-13) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#68) ```<br>* c4d2161 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-14) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#71) ```<br>* 61deb77 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-15) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
Code sync sonic-net/sonic-platform-common:202411 => 202412 ``` * d151d69 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250417:0530 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * f679a67 (base/202411) mssonicbld 250304:0402 - Restore optoe page to default 0 for active cables (sonic-net#550) | * c735073 Aryeh Feigin 250212:1628 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) | * b7e75d8 mssonicbld 250207:0102 - Add 800G innolight PNs (sonic-net#540) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the optoe's page to page ZERO before reading the Lower page > 127
Motivation and Context
When the module is busy with CDB command, the optoe kernel driver at the end of user page read request, tries to restore the page to Page ZERO and if this write fails because the module could be busy with CDB command (since these modules donot support background CDB mode). Because of this when Xcvrd tries to read offset (> 127) in Lower page, since optoe does not restore the page to 0 for any Lower page access, the page read to these offset will result in wrong page to be read (because of previous page select write failure) and Xcvrd parsing fails causing crash.
Now in optoe EEPROM read API we ensure to restore the Page to ZERO page if the Page select byte is non-zero
How Has This Been Tested?
TBD:
Additional Information (Optional)