[xcvrd] Fix crashing due to missing fields of some module types#54
Merged
jleveque merged 1 commit intosonic-net:masterfrom Aug 20, 2019
Merged
[xcvrd] Fix crashing due to missing fields of some module types#54jleveque merged 1 commit intosonic-net:masterfrom
jleveque merged 1 commit intosonic-net:masterfrom
Conversation
jleveque
suggested changes
Aug 20, 2019
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Can you please split this into two pull requests? One for the xcvrd fix, the other for making sonic_eeprom a symlink?
From SFF-8436 regarding cable length fields: "A value of zero means that the Module does not support (this mode) or that the length information must be determined from the Module technology." It is possible that all cable length fields in eeprom are 0, and this would lead to xcvrd crashing due to fetching of this data. Fallback is added in this case.
Contributor
Author
Removed the symlink change in this PR. Will create another PR with that change. Thanks |
jleveque
approved these changes
Aug 20, 2019
jleveque
changed the title
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
… 202412 (sonic-net#54) ```<br>* ca4e2cc - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-07) [Sonic Automation] * f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld] * c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From SFF-8436 regarding cable length fields:
"A value of zero means that the Module does not support [this mode] or that the length information must be determined from the Module technology."
It is possible that all cable length fields in eeprom are 0, and this would lead to xcvrd crashing due to fetching of this data. Fallback is added in this case.