Skip to content

Fix testbed_mtu for tasks that invoke fib_test#964

Merged
prsunny merged 2 commits intosonic-net:masterfrom
prsunny:master
Jun 19, 2019
Merged

Fix testbed_mtu for tasks that invoke fib_test#964
prsunny merged 2 commits intosonic-net:masterfrom
prsunny:master

Conversation

@prsunny
Copy link
Contributor

@prsunny prsunny commented Jun 18, 2019

Description of PR

FIB test now accepts configurable mtu as part of PR. Fixing bgp_speaker and warmboot tests which uses fib_test.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

Fix applied to bgp_speaker/warmboot yml

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@prsunny prsunny requested a review from yxieca June 18, 2019 03:04
@prsunny prsunny merged commit 08bf539 into sonic-net:master Jun 19, 2019
yxieca pushed a commit that referenced this pull request Jun 19, 2019
* Fix testbed_mtu for tasks that invoke fib_test

* Set socket buffer size to 16k
fraserg-arista pushed a commit to fraserg-arista/sonic-mgmt that referenced this pull request Feb 24, 2026
… for v6 topo (sonic-net#964)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->
Fix test_bgp_session_flap when memory stat is always 0, e.g., v4 neighbors memory usage in v6 topo.

Summary:
Fixes sonic-net#21450

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [x] 202412
- [x] 202505

### Approach
#### What is the motivation for this PR?
Fix test_bgp_session_flap.py for v6 topo

#### How did you do it?
Change memory comparison sign from less than to less than or equal to.

#### How did you verify/test it?
The test passed after the change

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants