Configurable MTU for FIB test#946
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 11, 2019
Merged
Conversation
lguohan
approved these changes
Jun 11, 2019
1 task
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
…-net#946) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fix the issue where PTF container is not reachable if MAC address was changed after rebuilding container. There will be a timeout for task "wait until ptf is reachable". When it happens, the gateway still uses the old MAC for the ptf container, which needs to be updated before initiating reachability test. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? PTF timeout after rebuilding PTF container. #### How did you do it? trigger GARP before PTF reachability test. #### How did you verify/test it? On local testbed. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Default to use jumbo frames for this test. MTU is configurable for any smaller values
Fixes # (issue)
Type of change
Approach
Use configured MTU for running FIB test
How did you do it?
Modify PTF test and pass MTU as a variable
How did you verify/test it?
Run the ansible test, Verify MTU value being passed to PTF:
"ptf --test-dir ptftests fib_test.FibTest --platform-dir ptftests --platform remote -t \"testbed_type='t1-lag';router_mac='90:b1:1c:f4:9d:40';fib_info='/root/fib_info.txt';ipv4=True;ipv6=True;testbed_mtu=9114\" --relax --debug info --log-file /tmp/fib_test.FibTest.ipv4.True.ipv6.True.2019-06-10-20:16:08.log --socket-recv-size 16384 2>&1"Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation