Skip to content

[action] [PR:9423] fix bgp update timer failure on dual tor#9473

Merged
mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld:cherry/202305/9423
Aug 18, 2023
Merged

[action] [PR:9423] fix bgp update timer failure on dual tor#9473
mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld:cherry/202305/9423

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Fix bgp update timer issue on dual tor env.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor.
Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of #8487.

How did you do it?

Config primary /secondary ip addresses on same physical interface.

How did you verify/test it?

re-run test on dual-tor env

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor.
Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of sonic-net#8487.

How did you do it?
Config primary /secondary ip addresses on same physical interface.

How did you verify/test it?
re-run test on dual-tor env
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #9423

Copy link
Copy Markdown
Contributor

@jcaiMR jcaiMR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld mssonicbld merged commit 7a523c2 into sonic-net:202305 Aug 18, 2023
@mssonicbld mssonicbld deleted the cherry/202305/9423 branch February 4, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants