fix bgp update timer failure on dual tor#9423
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Aug 15, 2023
Merged
Conversation
jcaiMR
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
approved these changes
Aug 15, 2023
Collaborator
There was a problem hiding this comment.
@jcaiMR LGTM.
but small question, when we use ip address other than ifconfig?
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 16, 2023
What is the motivation for this PR? Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor. Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of sonic-net#8487. How did you do it? Config primary /secondary ip addresses on same physical interface. How did you verify/test it? re-run test on dual-tor env
Collaborator
|
@jcaiMR PR conflicts with 202012 branch |
Collaborator
|
Cherry-pick PR to 202305: #9473 |
Collaborator
|
@jcaiMR PR conflicts with 202205 branch |
6 tasks
Contributor
Author
ifconfig will overwrite previous ip address, it's a kind of operation for primary address. ip address will add primary/secondary ip |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 18, 2023
What is the motivation for this PR? Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor. Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of #8487. How did you do it? Config primary /secondary ip addresses on same physical interface. How did you verify/test it? re-run test on dual-tor env
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This was referenced Sep 7, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor. Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of sonic-net#8487. How did you do it? Config primary /secondary ip addresses on same physical interface. How did you verify/test it? re-run test on dual-tor env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix bgp update timer issue on dual tor env.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix bug update timer issue on dual tor, when set up bgp speaker session with dual tor.
Interface selection on PTF has wrong behavior, config IP addresses within same subnet on different interfaces would case connection error. Refer to analysis of #8487.
How did you do it?
Config primary /secondary ip addresses on same physical interface.
How did you verify/test it?
re-run test on dual-tor env
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation