[action] [PR:9346] Revert the change to template acl.json. #9383
Merged
mssonicbld merged 1 commit intosonic-net:202012from Aug 10, 2023
Merged
[action] [PR:9346] Revert the change to template acl.json. #9383mssonicbld merged 1 commit intosonic-net:202012from
mssonicbld merged 1 commit intosonic-net:202012from
Conversation
Description of PR PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 . What is the motivation for this PR? PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <[email protected]>
6 tasks
Collaborator
Author
|
Original PR: #9346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
PR #9199 modified the template acl.json under folder
tests/crm/templatesand added a keyinput_interfacein this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 .Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #9199 modified the template acl.json under folder
tests/crm/templatesand added a keyinput_interfacein this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312How did you do it?
Revert the change to template acl json.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation