Revert the change to template acl.json. #9346
Merged
yutongzhang-microsoft merged 2 commits intosonic-net:masterfrom Aug 9, 2023
Merged
Revert the change to template acl.json. #9346yutongzhang-microsoft merged 2 commits intosonic-net:masterfrom
yutongzhang-microsoft merged 2 commits intosonic-net:masterfrom
Conversation
yutongzhang-microsoft
changed the title
input_interface in template acl.json.
yutongzhang-microsoft
changed the title
bingwang-ms
approved these changes
Aug 9, 2023
6 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 10, 2023
Description of PR PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 . What is the motivation for this PR? PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 10, 2023
Description of PR PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 . What is the motivation for this PR? PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 10, 2023
Description of PR PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 . What is the motivation for this PR? PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
Collaborator
|
Cherry-pick PR to 202305: #9382 |
Collaborator
|
Cherry-pick PR to 202205: #9381 |
Collaborator
|
Cherry-pick PR to 202012: #9383 |
This was referenced Aug 10, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Aug 10, 2023
Description of PR PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 . What is the motivation for this PR? PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
mssonicbld
added
Included in 202012 branch
and removed
Created PR to 202012 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 10, 2023
Description of PR PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 . What is the motivation for this PR? PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 12, 2023
Description of PR PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 . What is the motivation for this PR? PR #9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Description of PR PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 . What is the motivation for this PR? PR sonic-net#9199 modified the template acl.json under folder tests/crm/templates and added a key input_interface in this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR sonic-net#9312 How did you do it? Revert the change to template acl json. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
PR #9199 modified the template acl.json under folder
tests/crm/templatesand added a keyinput_interfacein this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312 .Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #9199 modified the template acl.json under folder
tests/crm/templatesand added a keyinput_interfacein this template. Only backend topo supports this key, so it will generate an error log in non-backend topo. In this PR, I revert the change to this template. And for recovery, we have another template in PR #9312How did you do it?
Revert the change to template acl json.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation