[renumber-topo] Add extra mgmt ip to ptf redeploy step#9230
Merged
wangxin merged 1 commit intosonic-net:masterfrom Aug 2, 2023
Merged
[renumber-topo] Add extra mgmt ip to ptf redeploy step#9230wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
wangxin
approved these changes
Aug 2, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of sonic-net#8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of sonic-net#8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
Collaborator
|
Cherry-pick PR to 202305: #15443 |
6 tasks
Contributor
|
We need this bugfix PR in 202305 branch. |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of #8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Follow up PR to #8432 which added support for extra mgmt IP in add-topo, but missed to update PTF redeploy,
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
If a testbed supports extra mgmt IP then the PTF gets the extra IP when
add-topois run. This change was done as part of #8432However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated.
This issue is fixed in this PR by adding extra mgmt IP support in
renumber_topoansible playbook.How did you do it?
How did you verify/test it?
Tested on physical testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation