[Testbed] Support config extra mgmt IP on PTF#8432
Merged
lizhijianrd merged 2 commits intosonic-net:masterfrom May 29, 2023
lizhijianrd:extra-ptf-mgmt-ip
Merged
[Testbed] Support config extra mgmt IP on PTF#8432lizhijianrd merged 2 commits intosonic-net:masterfrom lizhijianrd:extra-ptf-mgmt-ip
lizhijianrd merged 2 commits intosonic-net:masterfrom
lizhijianrd:extra-ptf-mgmt-ip
Conversation
wangxin
approved these changes
May 29, 2023
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Aug 2, 2023
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of #8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
What is the motivation for this PR? Support config extra MGMT IP addresses on PTF while add-topo. The extra IPs are used for non-routable traffic inside testbed. How did you do it? Updated add-topo related ansible playbooks and testbed-cli.sh to support this feature. How did you verify/test it? Verified on below situations: 1. Testbed without key ptf_extra_mgmt_ip. 2. Testbed with ptf_extra_mgmt_ip: []. 3. Testbed with ptf_extra_mgmt_ip: [<a-single-extra-ip>]. 4. Testbed with ptf_extra_mgmt_ip: [<extra-ip-1>, <extra-ip-2>]. Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? Support config extra MGMT IP addresses on PTF while add-topo. The extra IPs are used for non-routable traffic inside testbed. How did you do it? Updated add-topo related ansible playbooks and testbed-cli.sh to support this feature. How did you verify/test it? Verified on below situations: 1. Testbed without key ptf_extra_mgmt_ip. 2. Testbed with ptf_extra_mgmt_ip: []. 3. Testbed with ptf_extra_mgmt_ip: [<a-single-extra-ip>]. 4. Testbed with ptf_extra_mgmt_ip: [<extra-ip-1>, <extra-ip-2>]. Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of sonic-net#8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of sonic-net#8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? If a testbed supports extra mgmt IP then the PTF gets the extra IP when add-topo is run. This change was done as part of #8432 However, if PTF redeploy is done, the extra IP added by add-topo is lost as PTF is recreated. This issue is fixed in this PR by adding extra mgmt IP support in renumber_topo ansible playbook. How did you do it? How did you verify/test it? Tested on physical testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Support config extra MGMT IP addresses on PTF while add-topo. The extra IPs are used for non-routable traffic inside testbed.
How to use this feature
To configure multi MGMT IP addresses on PTF, update the
testbed.yamland add your extra MGMT addresses in the keyptf_extra_mgmt_ip. For example:After add-topo, we can find 3 IP addresses configured on the mgmt port:
To keep backward compatibility, key
ptf_extra_mgmt_ipis not required.Type of change
Back port request
Approach
What is the motivation for this PR?
Support config extra MGMT IP addresses on PTF while add-topo.
How did you do it?
Updated
add-toporelated ansible playbooks andtestbed-cli.shto support this feature.How did you verify/test it?
Verified on below situations:
ptf_extra_mgmt_ip.ptf_extra_mgmt_ip: [].ptf_extra_mgmt_ip: [<a-single-extra-ip>].ptf_extra_mgmt_ip: [<extra-ip-1>, <extra-ip-2>].Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation