[advanced-reboot] improvements and enable CPU/VLAN ARP watchers during warm reboot#890
Merged
yxieca merged 5 commits intosonic-net:masterfrom Apr 30, 2019
Merged
Conversation
added 4 commits
April 25, 2019 17:39
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
* reuse from_t1 and from_vlan_server generated packets in generate_bidirectional * use tcp instead ofudp in generate_bidirectional Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
reachability_watcher threads Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
* Apply a filter on socket before sending fast data plane IO * Save sniffed packets after the traffic test is done Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Contributor
Author
|
@yxieca Could you please review and test on your setup as well and check if you get stable CPU/VLAN ARP pings during reboot? |
Contributor
|
LGTM |
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Collaborator
|
The reachability watcher and the fast sender are both require the io lock to send IO. How could the watcher send anything when the fast sender is blocking sending for minutes? Your test log shows otherwise, I must be missing something? |
Contributor
Author
|
@yxieca Only |
yxieca
approved these changes
Apr 30, 2019
yxieca
pushed a commit
that referenced
this pull request
Apr 30, 2019
…g warm reboot (#890) * [advanced-reboot] move Arista class to seperate module Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [advanced-reboot] use lock to synchronize fast data plane and reachability_watcher threads Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [advanced-reboot] stabilize test when fast data plane send running * Apply a filter on socket before sending fast data plane IO * Save sniffed packets after the traffic test is done Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [advanced-reboot] refactor fast data plane generator code * reuse from_t1 and from_vlan_server generated packets in generate_bidirectional * use tcp instead ofudp in generate_bidirectional Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [advanced-reboot] add space back Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
1 task
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: BBR feature is not required in t1-isolated-xx setup, skip it for now. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? BBR feature is not required in t1-isolated-xx setup, skip it to reduce noise. #### How did you do it? skip in conditional mark. #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities d7e8f84cf..8c21fc151: > [utility] Filter FDB entries (sonic-net#890) > Fix the warm-reboot script to support FRR based warm-reboot (sonic-net#842) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[fwutil]: Fix firmware update command. (sonic-net#895) [utility] Filter FDB entries (sonic-net#890)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
The idea is to apply a filter on PTF socket while running send_in_background() to archive stable results
How did you do it?
When send_in_background() starts it locks dataplane_io_lock to guaranty data plane watcher will not run at the same time; before start sending traffic apply filter on ptf ports sockets to filter out data plane TCP traffic and ARP requests from DUT. Otherwise CPU/VLAN ARP states will be unstable
How did you verify/test it?
Ran warm reboot test on Mellanox DUT; The CPU/VLAN ARP is watched during the test in parallel to data plane traffic:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation