Skip to content

[storage_backend] Add testcase to test sub port stability#4490

Merged
lolyu merged 2 commits intosonic-net:masterfrom
lolyu:backend_sub_port_stability
Oct 26, 2021
Merged

[storage_backend] Add testcase to test sub port stability#4490
lolyu merged 2 commits intosonic-net:masterfrom
lolyu:backend_sub_port_stability

Conversation

@lolyu
Copy link
Collaborator

@lolyu lolyu commented Oct 14, 2021

Description of PR

Summary:
Fixes #3835

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Test sub port stability if some other sub ports are removed.

How did you do it?

Add test_routing_between_sub_ports_unaffected_by_sub_ports_removal to cover this scenario that it will verify the testing sub port still routes packets if some other sub ports are removed.

How did you verify/test it?

sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[same-TCP-UDP-ICMP-PORT] PASSED                                                                                                           [ 50%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[different-TCP-UDP-ICMP-PORT] PASSED                                                                                                      [100%]

========================================================================================================================= 2 passed in 521.30 seconds =========================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu requested a review from a team as a code owner October 14, 2021 12:55
@lolyu lolyu requested a review from neethajohn October 14, 2021 12:56
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 1 alert when merging 3d3fc65 into 4b157b8 - view on LGTM.com

new alerts:

  • 1 for Nested loops with same variable

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu
Copy link
Collaborator Author

lolyu commented Oct 21, 2021

/AZP run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu merged commit 2a044fa into sonic-net:master Oct 26, 2021
@lolyu lolyu deleted the backend_sub_port_stability branch October 26, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vlan class id remains unaffected after 1 subport is removed

2 participants