Skip to content

[vnet]: Wait for VNET routes to be applied to the HW#883

Merged
prsunny merged 1 commit intosonic-net:masterfrom
volodymyrsamotiy:vnet
Apr 22, 2019
Merged

[vnet]: Wait for VNET routes to be applied to the HW#883
prsunny merged 1 commit intosonic-net:masterfrom
volodymyrsamotiy:vnet

Conversation

@volodymyrsamotiy
Copy link
Copy Markdown
Contributor

Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [*] Test case(new/improvement)

Approach

How did you do it?

From time to time test could fail due to sending traffic when VNET config is not yet applied, so before sending any packet need to make sure that config is already applied.
To fix this just added sleep after configuring VNET routes in order to wait config to be applied to HW before sending traffic.

How did you verify/test it?

Ran ansible test few times and verified that it passed.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
@prsunny prsunny merged commit db1692a into sonic-net:master Apr 22, 2019
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…t#3112)

0ed90ba - [policerorch]: Fix return code comparison error (sonic-net#968) (1 minutes ago) <Shuotian Cheng)
80fcada -  remove crm acl_counters when acl_table removed (sonic-net#918) (3 hours ago) <JaredLius>
bd3651f - [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) (2 minutes ago) <Shuotian Cheng>
0af226a - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906) (4 weeks ago) <Shuotian Cheng>
9005962 - [vstest]: Update the mirror session state table name (sonic-net#917) (5 weeks ago) <Shuotian Cheng>
c4e3e54 - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889) (6 weeks ago) <Shuotian Cheng>
ee49926 - [Makefile]: Remove header files from source files (sonic-net#883) (8 weeks ago) <Shuotian Cheng>
f889f80 - [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) (8 weeks ago) <Shuotian Cheng>
9931450 - [aclorch]: Add MIRRORv6 and MIRRORv4v6 support for ACL table (sonic-net#825) (9 weeks ago) <Shuotian Cheng>
a1ab18c - [mirrororch]: Fix comments typo (sonic-net#863) (9 weeks ago) <Shuotian Cheng>

sonic-swss-common
485db07 - [schema]: Add SWITCH_CAPABILITY_TABLE (sonic-net#276) (6 weeks ago) <Shuotian Cheng>        
3f49b20 - [schema]: Add POLICER configuration table (sonic-net#277) (6 weeks ago) <Shuotian Cheng>    
539b87d - [schema]: Add STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#278) (6 weeks ago) <Shuotian Cheng>

sonic-utilities
dc52015 - [Sonic-utilities]: Added commands to view acl and port running configs (sonic-net#557) (6 days ago) <Prem Prakash>
635dc88 - [config]: Add config acl add/remove table command (sonic-net#541) (4 weeks ago) <Shuotian Cheng>
dcdc922 - [show]: Add show policer command (sonic-net#540) (4 weeks ago) <Shuotian Cheng>                                        
128462a - [config]: Add --policer option for mirror session (sonic-net#537) (6 weeks ago) <Shuotian Cheng>                       
38da7f3 - [acl_loader]: Add policer attribute in show mirror_session command (sonic-net#538) (6 weeks ago) <Shuotian Cheng>      
f95ff00 - [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (sonic-net#522) (6 weeks ago) <Shuotian Cheng>

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
… in test_bgp_update_timer.py (sonic-net#883)

Prevent IndexError when packets lack BGPUpdate layer during pcap parsing

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

The test is trying to decode an spurious IP pkt as BGPUpdate pkt
```
bgp_update = <CookedLinux  pkttype=sent-by-us lladdrtype=0x1 lladdrlen=6 src=b'\xe8\xe4\x9d\x00\xc4\xc6' proto=IPv4 |<IP  version=4...x00\x19\xc0\xa8\xf1\x80\x19\xc0\xa8\xf2\x00\x19\xc0\xa8\xf2\x80\x19\xc0\xa8\xf3\x00\x19\xc0\xa8\xf3\x80\x00\x00' |>>>>>
bgp_updates = <Sniffed: TCP:61 UDP:0 ICMP:0 Other:0>
```

The test expects there are no pkts other than BGPUpdate captured, and
then unconditionally tries to decode them. Adding a defensive check to
not process such pkts.

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [x] 202505
- [x] 202511

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants