-
Notifications
You must be signed in to change notification settings - Fork 1k
[VM]Add BGPSentinel testcase and testplan #8814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d2e920f
[VM]Add BGPSentinel testcase and testplan
guangyao6 4aa25f2
[VM]Remove no ipv6 nht config
guangyao6 2bb98de
[VM]Change comment for bgp sentinel
guangyao6 8431768
[VM]Change dut selection fixture
guangyao6 05b1121
[VM]Modify BGPSentinel testplan
guangyao6 ebf1934
[VM]Modify BGPSentinel test comments
guangyao6 8448554
[VM]Add without no-export testplan
guangyao6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| - [Overview](#overview) | ||
| - [Scope](#scope) | ||
| - [Testbed](#testbed) | ||
| - [Setup configuration](#setup-configuration) | ||
| - [Test cases](#test-cases) | ||
|
|
||
| ## Overview | ||
| The purpose is to test that BGPSentinel (BGPS) host will setup an IBGP connection to FRR. BGPSentinel (BGPS) will advertise and withdraw routes to FRR. As BGPSentinel session is IBGP and not directly connected to the DUT, this feature relies on V4 and V6 next hop tracking resolve via default configuration in FRR. | ||
|
|
||
| ### Scope | ||
| The test is targeting a running SONIC system with fully functioning configuration. The purpose of the test is not to test specific API, but functional testing of BGPSentinel configuration on SONIC system. | ||
|
|
||
| ### Testbed | ||
| The test will run on the following testbeds: | ||
| * t1-lag (vs) | ||
|
|
||
| ```txt | ||
| +-----+------+ | ||
| | VM2 (T2) | | ||
| +-----+------+ | ||
| | | ||
| | | ||
| | | ||
| +-------------------+---------------------+ +-------------------+ | ||
| | | | | | ||
| | DUT (T1) |................| PTF (BGPSentinel) | | ||
| | | | | | ||
| +-------+-------------------------+-------+ +-------------------+ | ||
| | | | ||
| | | (Advertise: 10.0.0.0/24, community: | ||
| | | no-export, higher local-preference) | ||
| +-----+------+ +-----+------+ | ||
| | VM0 (T0) | | VM1 (T0) | | ||
| +------------+ +------------+ | ||
| (Advertise: 10.0.0.0/24) | ||
|
|
||
| ----- EBGP Session | ||
| ..... IBGP Session | ||
| ``` | ||
|
|
||
| ## Setup configuration | ||
| This test doesn't require any configuration in ansible deployment. IBGP session between BGPSentinel (BGPS) host and DUT are created in set up phase of this case and are cleaned in tear down phase of this case. BGPSentinel (BGPS) host is simulated by exabgp in PTF. | ||
|
|
||
| ## Test | ||
| The test will configure BGPSentinel session and then check that IBGP session would be setup between BGPSentinel (BGPS) host and DUT. After session set up, BGPSentinel (BGPS) will advertise routes with higher local-preference and no-export community. These routes will act as best-path in DUT, which would suppress routes received from t0. The test will cover both V4 and V6 BGPSentinel session. | ||
|
|
||
| ## Test cases | ||
bpar9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ### Test case # 1 - BGPSentinel to DUT over IBGP V4 session | ||
|
|
||
| #### Test Objective | ||
| Test BGPSentinel V4 session would be used to advertise and withdraw V4/V6 routes | ||
|
|
||
| #### Test Steps | ||
| 1. Setup IBGP V4 session from BGPSentinel (BGPS) host to DUT (Simulated from ptf using exabgp to DUT). | ||
| 2. Find V4 and V6 routes advertised from T0. | ||
| 3. Check these routes are advertised to EBGP peers. | ||
| 4. In ptf, advertise the same routes with higher local-preference and no-export community to DUT. | ||
yxieca marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 5. Check these routes are suppressed and not advertised to EBGP peers. | ||
| 6. In ptf, withdraw these routes to DUT. | ||
| 7. Check these routes are advertised to EBGP peers. | ||
|
|
||
| ### Test case # 2 - BGPSentinel to DUT over IBGP V6 session | ||
| Add BGPSentinel to DUT and check IBGP V6 session would set up and advertise V4/V6 routes | ||
|
|
||
| #### Test Objective | ||
| Test BGPSentinel V6 session would be used to advertise and withdraw V4/V6 routes | ||
|
|
||
| #### Test Steps | ||
| 1. Setup IBGP V6 session from BGPSentinel (BGPS) host to DUT (Simulated from ptf using exabgp to DUT). | ||
| 2. Find V4 and V6 routes advertised from T0. | ||
| 3. Check these routes are advertised to EBGP peers. | ||
| 4. In ptf, advertise the same routes with higher local-preference and no-export community to DUT. | ||
| 5. Check these routes are suppressed and not advertised to EBGP peers. | ||
| 6. In ptf, withdraw these routes to DUT. | ||
| 7. Check these routes are advertised to EBGP peers. | ||
|
|
||
| ### Test case # 3 - Soft/Hard reset IBGP V4 and V6 Session in DUT | ||
| Soft/Hard reset IBGP session, after IBGP session recovers, DUT would still suppress the route to T2 peers | ||
|
|
||
| #### Test Objective | ||
| Test after soft/hard reset IBGP session, DUT would still select right best path | ||
|
|
||
| #### Test Steps | ||
| 1. Setup IBGP V6 session from BGPSentinel (BGPS) host to DUT (Simulated from ptf using exabgp to DUT). | ||
| 2. Find V4 and V6 routes advertised from T0. | ||
| 3. Check these routes are advertised to EBGP peers. | ||
| 4. In ptf, advertise the same routes with higher local-preference and no-export community to DUT. | ||
| 5. Check these routes are suppressed and not advertised to EBGP peers. | ||
| 6. Soft/Hard reset IBGP session, wait for IBGP session setup. | ||
| 7. Check these routes are till suppressed and not advertised to EBGP peers. | ||
| 8. In ptf, withdraw these routes to DUT. | ||
| 9. Check these routes are advertised to EBGP peers. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.