[VM]Add BGPSentinel testcase and testplan#8814
Merged
yxieca merged 7 commits intosonic-net:masterfrom Aug 15, 2023
Merged
Conversation
guangyao6
requested review from
StormLiangMS,
jcaiMR,
wangxin and
yxieca
as code owners
jcaiMR
reviewed
Jul 6, 2023
jcaiMR
reviewed
Jul 6, 2023
yxieca
requested changes
Jul 6, 2023
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Please schedule a time to present test plan in the test subgroup meeting.
bpar9
requested changes
Jul 26, 2023
wangxin
previously approved these changes
Jul 31, 2023
bpar9
previously approved these changes
Aug 1, 2023
yxieca
approved these changes
Aug 15, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? In SONiC, a new peer-group (BGPSentinel) is added in BGP configuration. This testcase is to verify that IBGP session would be established between DUT and BGPSentinel host (simulated by exabgp in ptf). And to verify exabgp in BGPSentinel host would advertise and withdraw route to DUT. How did you do it? Using t1-lag topology, and configure route in ptf to ensure that ptf and dut would ping each other. Add BGPSentinel configuration in DUT and start exabgp in ptf to setup IBGP connection. Advertise route from ptf with higher local-preference and no-export community to DUT, check route in DUT would be suppressed. Withdraw route from ptf, check route in DUT would be advertised to EBGP peers. How did you verify/test it? Setup t1-lag topology. Using command "./run_tests.sh -m individual -a False -n vms-kvm-t1-lag -u -c bgp/test_bgp_sentinel.py -f vtestbed.yaml -i veos_vtb -e "--neighbor_type=eos"" to run testcase. Testcase would pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add BGPSentinel testcase and testplan
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In SONiC, a new peer-group (BGPSentinel) is added in BGP configuration. This testcase is to verify that IBGP session would be established between DUT and BGPSentinel host (simulated by exabgp in ptf). And to verify exabgp in BGPSentinel host would advertise and withdraw route to DUT.
How did you do it?
How did you verify/test it?
Setup t1-lag topology. Using command "./run_tests.sh -m individual -a False -n vms-kvm-t1-lag -u -c bgp/test_bgp_sentinel.py -f vtestbed.yaml -i veos_vtb -e "--neighbor_type=eos"" to run testcase. Testcase would pass.
Any platform specific information?
Supported testbed topology if it's a new test case?
t1-lag
Documentation