update BufferPoolWatermarkTest for cisco-8000 hbm#8607
Closed
zhixzhu wants to merge 1 commit intosonic-net:202205from
Closed
update BufferPoolWatermarkTest for cisco-8000 hbm#8607zhixzhu wants to merge 1 commit intosonic-net:202205from
zhixzhu wants to merge 1 commit intosonic-net:202205from
Conversation
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
Collaborator
|
@zhixzhu Is this a backport of master branch PR to 202205 branch? Can you mention the master branch PR ID here in PR description? |
Contributor
Author
No, I didn't create master branch PR for this. |
Collaborator
|
@zhixzhu Can you close this one and create PR to master branch instead? After the PR to master branch is merged, then we can backport it to 202205 branch. The master branch is supposed to include everything. If some fixes are only made to release branch, in the future we have to fix it again in master branch and later release branches. There would be duplicated work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
After enable hbm for long-link, the bufferpool for lossless is hbm.
Before packets are evicted to hbm, the bufferpool watermark will always be 0.
Once hit the eviction threshold, the whole voq is evicted to hbm, and the bufferpool watermark will be increased once by a large value.
Send pkts_num_fill_ingr_min packets as initial, which is one packet less than eviction threshold, bufferpool watermark is 0.
Before the while loop, set expected_wm = pkts_num_fill_min * cell_occupancy.
Then in while loop, the expected_wm will be added up to the correct value.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation