Change warm-reboot time limit to 1 second#855
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Apr 5, 2019
Merged
Conversation
yxieca
reviewed
Apr 4, 2019
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
This parameter can be overriden with test parameter, we should use test parameter instead of changing code.
Contributor
|
but the default should 1 second, this is changing the default. |
lguohan
approved these changes
Apr 5, 2019
yxieca
pushed a commit
that referenced
this pull request
Apr 5, 2019
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
… (sonic-net#855) * Add qos params for Arista-7060X6-64PE-B-O128 cherry-pick sonic-net#20954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with Mellanox DUT.
By definition, warm-reboot data plane disruption should be less than 1 second. If some platform implementation achieve better, we could override it specially.