Skip to content

Add qos params for topos ft2-64, lt2-p32o64, lt2-o128#20954

Merged
bingwang-ms merged 4 commits intosonic-net:masterfrom
rick-arista:lt2-o128
Nov 11, 2025
Merged

Add qos params for topos ft2-64, lt2-p32o64, lt2-o128#20954
bingwang-ms merged 4 commits intosonic-net:masterfrom
rick-arista:lt2-o128

Conversation

@rick-arista
Copy link
Contributor

@rick-arista rick-arista commented Oct 8, 2025

Description of PR

Summary:
Adds qos test params for:

  • ft2-64
  • lt2-p32o64
  • lt2-o128

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

Manually ran qos/test_qos_sai.py tests, output:

topo-ft2-64:
qos/test_qos_sai.py::TestQosSai::testParameter[single_asic] PASSED                                                                                                                                                                                                                
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueue[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgHeadroomWatermark[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic] PASSED
======== 14 passed, 266 skipped, 1 warning in 2989.80s (0:49:49) =====================================

topo-lt2-p32o64:
qos/test_qos_sai.py::TestQosSai::testParameter[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueue[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgHeadroomWatermark[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic] PASSED
======== 14 passed, 266 skipped, 1 warning in 3483.55s (0:58:03) =====================================

topo-lt2-o128:
qos/test_qos_sai.py::TestQosSai::testParameter[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_asic-xoff_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_1] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[single_asic-xon_2] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueue[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[single_asic-wm_pg_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiPgHeadroomWatermark[single_asic] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossless] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy] PASSED
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic] PASSED
======== 14 passed, 266 skipped, 1 warning in 3559.45s (0:59:19) =====================================

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@XuChen-MSFT
Copy link
Contributor

@rick-arista Have you run all QoS tests to see if there are any key errors?
Recently, some newly built topologies were missing some QoS parameters, resulting in key errors.

@bingwang-ms
Copy link
Collaborator

@rick-arista Can you also make the change for another topo topo-lt2-p32o64 and topo_ft2-p64?

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rick-arista
Copy link
Contributor Author

Hi @XuChen-MSFT and @bingwang-ms. I've updated this PR with topo-lt2-p32o64 params. I'll add the topo_ft2-p64 params shortly. These were all manually tested and I dont recall seeing any key errors.

@bingwang-ms
Copy link
Collaborator

Thanks @rick-arista . Earlier you mentioned there was some code change that needs to be backported. Can you share the PR for that if you already have?

@rick-arista
Copy link
Contributor Author

@bingwang-ms A separate backport PR has been opened against the branch directly

@bingwang-ms
Copy link
Collaborator

Hi @rick-arista, would you mind fill the PR template properly and also include a test result so that we can have this PR merged?

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rick-arista
Copy link
Contributor Author

@bingwang-ms I've added the ft2-64 params. I'll run the qos tests for these topos today and update the PR description with the results. Will also fix the PR title and template

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rick-arista rick-arista changed the title Add qos params for Arista-7060X6-64PE-B-O128 Add qos params for topos ft2-64, lt2-p32o64, lt2-o128 Oct 31, 2025
@rick-arista
Copy link
Contributor Author

@bingwang-ms @XuChen-MSFT

I've updated the params for these 3 topos, and fixed the title and description of this PR. I've also addressed the comments in the associated PR for the for the test fixes that needed to be backported.

Copy link
Collaborator

@bingwang-ms bingwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit c324cd2 into sonic-net:master Nov 11, 2025
16 checks passed
bingwang-ms added a commit to Azure/sonic-mgmt.msft that referenced this pull request Nov 11, 2025
@bingwang-ms
Copy link
Collaborator

Included in 202503 with PR Azure/sonic-mgmt.msft#855

dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
vikumarks pushed a commit to vikumarks/sonic-mgmt that referenced this pull request Dec 1, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: vikumarks <[email protected]>
albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Dec 2, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Alberto Villarreal <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: opcoder0 <[email protected]>
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Dec 9, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Nishanth Sampath Kumar <[email protected]>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: selldinesh <[email protected]>
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Saravanan <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: YiFan Wang <[email protected]>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Yael Tzur <[email protected]>
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
* Add qos params for Arista-7060X6-64PE-B-O128

Signed-off-by: Raghavendran Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants