Skip to content

Reverted VNET Vxlan test params to prevent route configuration issues#8379

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
AharonMalkin:vnet_fix
May 24, 2023
Merged

Reverted VNET Vxlan test params to prevent route configuration issues#8379
bingwang-ms merged 1 commit intosonic-net:masterfrom
AharonMalkin:vnet_fix

Conversation

@AharonMalkin
Copy link
Contributor

Description of PR

Vnet Vxlan test fails with the current params: 16K routes, 1 vnets, and 4K endpoints.
The test fails due to a combination of ipv4 and ipv6 tunnels, due to ipv6 parameter enabled on sonic-mgmt branch.
The ipv6 is disabled on 202205 branch, and the number of vnets is 1 instead of 8 in the 202211 branch.
The PR reverts the parameters back to the 202205 values, the test passes with those parameters.

Summary:
The PR is related to bug #8374, where the route configuration is not applied correctly.
The PR is reverting the test params back to 202205 configuration.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Reverting changes done on #6212, which changes the parameters of the test, as the test doesn't pass with them.

How did you do it?

Changed the parameter on conftest.py to 202205 conf

How did you verify/test it?

ran the vnet_vxlan test parameters with 202205 a few times.

Any platform specific information?

Runs on to topo.

@AharonMalkin AharonMalkin requested a review from prgeor as a code owner May 22, 2023 08:49
@AharonMalkin
Copy link
Contributor Author

@roy-sror

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/sfp/conftest.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@bingwang-ms bingwang-ms merged commit 8825db5 into sonic-net:master May 24, 2023
AharonMalkin added a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…onic-net#8379) (sonic-net#11530)

- Why I did it
New SN410 A1 system has a different sensor layout with A0 system, needs a new sensor conf file to support it.

- How I did it
Since the SN4410 A1 system use exactly the same sensor layout as the SN4700 A1 system, so add a symbol link linking to the SN4700 A1 sensor conf file to reuse.

- How to verify it
Run sensor test against the SN4410 A1 system;
Run platform related regression test against the SN4410 A1 system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants