BFD+VXLAN Automation#6212
Conversation
Updating the fork
|
This pull request introduces 18 alerts and fixes 5 when merging 80124202714a42af6186655c23658509584c681c into 5a7b5a0 - view on LGTM.com new alerts:
fixed alerts:
|
|
@siqbal1986 - I cleared those CLA errors. Now, reviewers can be added. |
|
This pull request introduces 19 alerts and fixes 5 when merging cff8962 into 9b5a439 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 19 alerts and fixes 5 when merging 7381622 into 176a2fe - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 19 alerts and fixes 5 when merging ab3ca28 into 00b9f3e - view on LGTM.com new alerts:
fixed alerts:
|
|
Can you please specify which Vxlan tests you ran with the BFD exactly? |
|
This pull request introduces 19 alerts and fixes 5 when merging d28e7d1 into 9ef9448 - view on LGTM.com new alerts:
fixed alerts:
|
|
Hi @siqbal1986 , Here are the Test cases that will work with BFD: Test_VxLAN_ecmp_create Test_VxLAN_NHG_Modify |
|
This pull request introduces 19 alerts and fixes 5 when merging 0bb7626 into 9ef9448 - view on LGTM.com new alerts:
fixed alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
This pull request introduces 12 alerts and fixes 3 when merging 60cba0f into 5ead051 - view on LGTM.com new alerts:
fixed alerts:
|
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
This pull request introduces 12 alerts and fixes 3 when merging 108efe3 into da0aae7 - view on LGTM.com new alerts:
fixed alerts:
|
|
@gollarharsha please check the pre-commit-check failures and fix it. |
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
Adding logs from the last changes. |
|
This pull request introduces 14 alerts and fixes 3 when merging b82073d into e0ede4d - view on LGTM.com new alerts:
fixed alerts:
|
1. Updated the traffic script to pump all the packets of an iteration in one go, and then wait in a timed-loop for reply packets. This speeds up the traffic script greatly. The full runtime is now 3.5 hours. 2. Added --include_long_tests argument, so that user can run basic tests by default(45 minutes runtime for all 4 encap types). If the long tests are included, the total runtime is now 3.5 hours. 3. Updated the scripts for improved pylint score. The new scores: a) test_vxlan_ecmp.py: 8.89/10 b) vxlan_traffic.py : 7.18/10 c) vxlan_ecmp_utils.py : 9.31/10
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
This pull request introduces 6 alerts and fixes 6 when merging 90362dd into 8580f64 - view on LGTM.com new alerts:
fixed alerts:
|
… flake8 checks are clean. (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 ansible/roles/test/files/ptftests/vxlan_traffic.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 ansible/roles/test/files/ptftests/bfd_responder.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/test_vxlan_ecmp.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/vxlan_ecmp_utils.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/conftest.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# Run and verified: iINFO:root:Can not get Allure report URL. Please check logs =========================== short test summary info ============================ SKIPPED [4] vxlan/test_vxlan_ecmp.py:1962: This test will be run only if '--include_crm=True' is provided. SKIPPED [4] vxlan/test_vxlan_ecmp.py:1908: This test will be run only if '--include_crm=True' is provided. SKIPPED [4] vxlan/test_vxlan_ecmp.py:1948: This test will be run only if '--include_crm=True' is provided. ERROR vxlan/test_vxlan_ecmp.py::Test_VxLAN_Crm::test_crm_128_group_members[v6_in_v6] ============= 104 passed, 12 skipped, 1 error in 10992.56 seconds ==============
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
This pull request introduces 4 alerts and fixes 12 when merging d62bc03 into 8580f64 - view on LGTM.com new alerts:
fixed alerts:
|
|
|
@siqbal1986, pls merge it. |
|
@siqbal1986 , is this planned to be cherry-picked to 202012 or raising a separate PR? |
I don't think automatic cherry pick on this would work. @gollarharsha @rraghav-cisco I think a separate PR would be required. Can you please raise one |
|
@siqbal1986 and @prsunny, I will take it up. |
|
@ihorchekh , can you please check if all comments were addressed and signoff? |
|
@prsunny , @siqbal1986 : I have raised #6807 |
1. Updated the traffic script to pump all the packets of an iteration in one go, and then wait in a timed-loop for reply packets. This speeds up the traffic script greatly. The full runtime is now 3.5 hours. 2. Added --include_long_tests argument, so that user can run basic tests by default(45 minutes runtime for all 4 encap types). If the long tests are included, the total runtime is now 3.5 hours. 3. Updated the scripts for improved pylint score. The new scores: a) test_vxlan_ecmp.py: 8.89/10 b) vxlan_traffic.py : 7.18/10 c) vxlan_ecmp_utils.py : 9.31/10 * Re-formatted and fixed the scripts to pass the pre-commit checks. All flake8 checks are clean. (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 ansible/roles/test/files/ptftests/vxlan_traffic.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 ansible/roles/test/files/ptftests/bfd_responder.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/test_vxlan_ecmp.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/vxlan_ecmp_utils.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# flake8 tests/vxlan/conftest.py (venv3) RRAGHAV-M-C3KR:sonic-mgmt-hgolla root# Run and verified: iINFO:root:Can not get Allure report URL. Please check logs =========================== short test summary info ============================ SKIPPED [4] vxlan/test_vxlan_ecmp.py:1962: This test will be run only if '--include_crm=True' is provided. SKIPPED [4] vxlan/test_vxlan_ecmp.py:1908: This test will be run only if '--include_crm=True' is provided. SKIPPED [4] vxlan/test_vxlan_ecmp.py:1948: This test will be run only if '--include_crm=True' is provided. ERROR vxlan/test_vxlan_ecmp.py::Test_VxLAN_Crm::test_crm_128_group_members[v6_in_v6] ============= 104 passed, 12 skipped, 1 error in 10992.56 seconds ============== Co-authored-by: rraghav-cisco <rraghav@cisco.com>
BFD automation with VXLAN was done for the first 3 cases:
Here are additional changes that were added:
As discussed in last session, I have enabled BFD in the same file as VXLAN. By passing bfd argument, we should be able to run existing VXLAN test cases.
Bfd_sniffer script will extract BFD packets and automatically populate the config file for bfd_responder.
Cleanup for BFD was added in existing vxlan script itself.
I have ran first 3 test cases for all 4 encap types. All 12 cases passed as well.