[dualtor-aa] Fix test_fdb[ethernet]#8158
Merged
lolyu merged 1 commit intosonic-net:masterfrom May 11, 2023
Merged
Conversation
lolyu
force-pushed
the
dualtor_aa_fix_test_fdb
branch
from
788cacf to
8668d59
Compare
Collaborator
|
@lolyu this is effectively testing fdb in active-standby mode. Should we collect all active ports and expect IO from them? That way the test case is naturally fits both active-standby and active-active. |
yxieca
previously approved these changes
Apr 28, 2023
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Please fie test gap, you can move on with this PR for now.
xwjiang-ms
previously approved these changes
May 10, 2023
For pkt_type etherent, the packets to populate the fdb are ECMPed to either ToRs, neither of the ToRs could have the full set of fdb entries. And as the I/O also gets ECMPed in the validation step, the I/O could not be guaranteed to be forwarded to the ToR that has the corresponding fdb entry. Let's fall back to active-standby mode to test this scenario for active-active ports. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
dualtor_aa_fix_test_fdb
branch
from
8668d59 to
a73146a
Compare
wsycqyz
approved these changes
May 10, 2023
wangxin
pushed a commit
that referenced
this pull request
May 16, 2023
Approach What is the motivation for this PR? Fix test_fdb[ethernet] failure on dualtor-aa testbed. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? For pkt_type etherent, the packets to populate the fdb are ECMPed to either ToRs, neither of the ToRs could have the full set of fdb entries. And as the I/O also gets ECMPed in the validation step, the I/O could not be guaranteed to be forwarded to the ToR that has the corresponding fdb entry. Let's fall back to active-standby mode to test this scenario for active-active ports. How did you verify/test it? Run on dualtor-aa testbed.
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
Approach What is the motivation for this PR? Fix test_fdb[ethernet] failure on dualtor-aa testbed. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? For pkt_type etherent, the packets to populate the fdb are ECMPed to either ToRs, neither of the ToRs could have the full set of fdb entries. And as the I/O also gets ECMPed in the validation step, the I/O could not be guaranteed to be forwarded to the ToR that has the corresponding fdb entry. Let's fall back to active-standby mode to test this scenario for active-active ports. How did you verify/test it? Run on dualtor-aa testbed.
7 tasks
4 tasks
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Approach What is the motivation for this PR? Fix test_fdb[ethernet] failure on dualtor-aa testbed. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? For pkt_type etherent, the packets to populate the fdb are ECMPed to either ToRs, neither of the ToRs could have the full set of fdb entries. And as the I/O also gets ECMPed in the validation step, the I/O could not be guaranteed to be forwarded to the ToR that has the corresponding fdb entry. Let's fall back to active-standby mode to test this scenario for active-active ports. How did you verify/test it? Run on dualtor-aa testbed.
This was referenced Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix
test_fdb[ethernet]failure ondualtor-aatestbed.Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
For pkt_type etherent, the packets to populate the fdb are ECMPed to
either ToRs, neither of the ToRs could have the full set of fdb entries.
And as the I/O also gets ECMPed in the validation step, the I/O could
not be guaranteed to be forwarded to the ToR that has the corresponding
fdb entry.
Let's fall back to active-standby mode to test this scenario for
active-active ports.
How did you verify/test it?
Run on
dualtor-aatestbed.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation