Skip to content

fix the everflow testbed failure on dualtor A-A#11351

Closed
svelamal wants to merge 2 commits intosonic-net:masterfrom
svelamal:everflow_2
Closed

fix the everflow testbed failure on dualtor A-A#11351
svelamal wants to merge 2 commits intosonic-net:masterfrom
svelamal:everflow_2

Conversation

@svelamal
Copy link
Copy Markdown
Contributor

@svelamal svelamal commented Jan 19, 2024

Description of PR

After debug and investigation, this failure of "test_everflow_testbed" on dualtor A-A including two issues:

the mux status is standby on the selected DUT.
the test pkts are not sent to selected DUT, which has everflow rule config.
The rootcause of 1 is due to BGP shutdown. In the script, it tries to shutdown all BGP during setup, which makes T1 not reachable from the TOR. Then the DUT moves itself into standby mode. That's from the design of mux state machine.

The rootcause of 2 is similiar to the following issue:
#8158

We need fall back to active-standby mode to test this scenario for
active-active ports.

Summary:
Fixes # (issue)
Fixes # (#9983)

Type of change

  • Bug fix
  • [x ] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • [x ] 202205
  • [x ] 202305

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Verified on A-A

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_testbed.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/everflow/test_everflow_testbed.py:151:40: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor' from line 21
tests/everflow/test_everflow_testbed.py:252:43: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor' from line 21
tests/everflow/test_everflow_testbed.py:321:51: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor' from line 21
tests/everflow/test_everflow_testbed.py:413:49: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor' from line 21
tests/everflow/test_everflow_testbed.py:525:13: F811 redefinition of unused 'toggle_all_simulator_ports_to_rand_selected_tor' from line 21
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_testbed.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@svelamal
Copy link
Copy Markdown
Contributor Author

Trailing whitespace is not introduced in this PR. Seems to have been there before too (#7748)

Copy link
Copy Markdown
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your PR description.

@svelamal
Copy link
Copy Markdown
Contributor Author

Please format your PR description.

Done

Copy link
Copy Markdown
Contributor

@XuChen-MSFT XuChen-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and pass local test

@kevinskwang
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_testbed.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@kevinskwang
Copy link
Copy Markdown
Contributor

@svelamal pls fix the pr test failure

@lolyu
Copy link
Copy Markdown
Collaborator

lolyu commented Mar 19, 2024

PR is obsolete, changes are included in #12022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants