Fix fanout SSH authentication failed issue#8054
Merged
wangxin merged 1 commit intosonic-net:masterfrom Apr 18, 2023
Merged
Conversation
PR sonic-net#7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable `ansible_ssh_password` instead of expected `ansible_ssh_pass`. Consequently, deploy fanout switch failed with authentication failure. This change corrected variable name `ansible_ssh_password` to `ansible_ssh_pass` in the touched files. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Xichen96
approved these changes
Apr 17, 2023
wangxin
added a commit
that referenced
this pull request
Apr 20, 2023
What is the motivation for this PR? PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable ansible_ssh_password instead of expected ansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure. How did you do it? This change corrected variable name ansible_ssh_password to ansible_ssh_pass in the touched files. How did you verify/test it? Run playbook fanout.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
wangxin
added a commit
that referenced
this pull request
Apr 20, 2023
What is the motivation for this PR? PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable ansible_ssh_password instead of expected ansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure. How did you do it? This change corrected variable name ansible_ssh_password to ansible_ssh_pass in the touched files. How did you verify/test it? Run playbook fanout.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable
ansible_ssh_passwordinstead of expectedansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure.How did you do it?
This change corrected variable name
ansible_ssh_passwordtoansible_ssh_passin the touched files.How did you verify/test it?
Run playbook fanout.yml.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation