[ansible] Consider tacacs when deploying fanout#7778
[ansible] Consider tacacs when deploying fanout#7778Blueve merged 5 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
What is the motivation for this PR? There is a need to add tacacs account to fanout without affecting current fanout devices that still uses local credentials. How did you do it? Add fanout_tacacs_sonic_user/password that can override fanout_sonic_user/password, and also a fanout_tacacs_user/password that can override fanout_tacacs_sonic_user/password. How did you verify/test it? Verified in lab. Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
What is the motivation for this PR? There is a need to add tacacs account to fanout without affecting current fanout devices that still uses local credentials. How did you do it? Add fanout_tacacs_sonic_user/password that can override fanout_sonic_user/password, and also a fanout_tacacs_user/password that can override fanout_tacacs_sonic_user/password. How did you verify/test it? Verified in lab. Signed-off-by: Xichen Lin <lukelin0907@gmail.com>
PR sonic-net#7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable `ansible_ssh_password` instead of expected `ansible_ssh_pass`. Consequently, deploy fanout switch failed with authentication failure. This change corrected variable name `ansible_ssh_password` to `ansible_ssh_pass` in the touched files. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
What is the motivation for this PR? PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable ansible_ssh_password instead of expected ansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure. How did you do it? This change corrected variable name ansible_ssh_password to ansible_ssh_pass in the touched files. How did you verify/test it? Run playbook fanout.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
What is the motivation for this PR? PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable ansible_ssh_password instead of expected ansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure. How did you do it? This change corrected variable name ansible_ssh_password to ansible_ssh_pass in the touched files. How did you verify/test it? Run playbook fanout.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
What is the motivation for this PR? PR #7778 added support of SSH to fanout switch using TACACS account. However, this PR introduced an issue. It mistakenly set SSH password to variable ansible_ssh_password instead of expected ansible_ssh_pass. Consequently, deploy fanout switch failed with authentication failure. How did you do it? This change corrected variable name ansible_ssh_password to ansible_ssh_pass in the touched files. How did you verify/test it? Run playbook fanout.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Description of PR
Currently when deploying fanout, only the variable fanout_sonic_user/password, fanout_eos_user/password is considered. I add ansible_tacacs_user/password, ansible_tacacs_sonic/password that can override fanout_eos_user so current setup will not be broken.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is a need to add tacacs account to fanout without affecting current fanout devices that still uses local credentials.
How did you do it?
Add fanout_tacacs_sonic_user/password that can override fanout_sonic_user/password, and also a fanout_tacacs_user/password that can override fanout_tacacs_sonic_user/password.
How did you verify/test it?
Verified in lab.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation