Skip to content

[voq][chassis] Use system port name for BUFFER_QUEUE_TABLE in a voq chassis.#7823

Merged
vmittal-msft merged 1 commit intosonic-net:masterfrom
sanmalho-git:qos_sys_port
Mar 23, 2023
Merged

[voq][chassis] Use system port name for BUFFER_QUEUE_TABLE in a voq chassis.#7823
vmittal-msft merged 1 commit intosonic-net:masterfrom
sanmalho-git:qos_sys_port

Conversation

@sanmalho-git
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

PR# 14173 (sonic-net/sonic-buildimage#14173) updates to set buffer_queue_config on system ports on a VoQ chassis.

This broke the QoS tests in _getBufferProfile for BUFFER_QUEUE_TABLE

How did you do it?

Fix was to use system port name (derived from hostname and asic instance) when dealing with voq chassis and BUFFER_QUEUE_TABLE

How did you verify/test it?

Ran QoS tests against latest 202205 based image

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

PR# 14173 (sonic-net/sonic-buildimage#14173) updates
to set buffer_queue_config on system ports on a VoQ chassis.

This broke the QoS tests in _getBufferProfile for BUFFER_QUEUE_TABLE

Fix was to use system port name (derived from hostname and asic instance) when
dealing with voq chassis and BUFFER_QUEUE_TABLE
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/qos_sai_base.py:22:1: F401 'tests.common.system_utils.docker' imported but unused
tests/qos/qos_sai_base.py:87:121: E501 line too long (127 > 120 characters)
tests/qos/qos_sai_base.py:234:21: E251 unexpected spaces around keyword / parameter equals
tests/qos/qos_sai_base.py:234:23: E251 unexpected spaces around keyword / parameter equals
tests/qos/qos_sai_base.py:632:79: E202 whitespace before '}'
tests/qos/qos_sai_base.py:641:82: E202 whitespace before '}'
tests/qos/qos_sai_base.py:775:85: F811 redefinition of unused 'get_mux_status' from line 15
tests/qos/qos_sai_base.py:795:39: F811 redefinition of unused 'docker' from line 22
tests/qos/qos_sai_base.py:947:9: E722 do not use bare 'except'
tests/qos/qos_sai_base.py:958:121: E501 line too long (121 > 120 characters)
tests/qos/qos_sai_base.py:959:121: E501 line too long (127 > 120 characters)
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@vmittal-msft vmittal-msft merged commit 204d09e into sonic-net:master Mar 23, 2023
wangxin pushed a commit that referenced this pull request Mar 24, 2023
PR# 14173 (sonic-net/sonic-buildimage#14173) updates
to set buffer_queue_config on system ports on a VoQ chassis.
This broke the QoS tests in _getBufferProfile for BUFFER_QUEUE_TABLE
Fix was to use system port name (derived from hostname and asic instance) when
dealing with voq chassis and BUFFER_QUEUE_TABLE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants