Skip to content

Fix QOS tests to run on 64p topo#23325

Open
arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
arista-nwolfe:master-64p-qos-fix
Open

Fix QOS tests to run on 64p topo#23325
arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
arista-nwolfe:master-64p-qos-fix

Conversation

@arista-nwolfe
Copy link
Contributor

64 port topos like topo_t2_single_node_max_64p and topo_t2_single_node_max_64p_v2 won't run qos/test_qos_sai.py because the skip conditionals explicitly call out the topology names:

topo_name not in (constants['QOS_SAI_TOPO'] + ['t2_single_node_max', 't2_single_node_min'])

This change will group any topo with t2_single_node* in the condition.

Also fixing an issue where we used the wrong system_port key on single-asic VOQ systems.
Without this we see the following failures:

>           wredProfileName = "WRED_PROFILE|" + six.text_type(dut_asic.run_redis_cmd(
                argv=[
                    "redis-cli", "-n", "4", "HGET",
                    "{0}|{1}|{2}".format(table, port, self.TARGET_QUEUE_WRED),
                    "wred_profile"
                ]
            )[0])
E           IndexError: list index out of range

It's trying to read the key QUEUE|Ethernet0|3 when it should be QUEUE|ctn101|Asic0|Ethernet0|3.
I believe this was an oversight when #20544 was added (only supports multi_asic).
Instead the conditional should've been more like #7823 and hardcode the Asic0 in the case of single-asic systems.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Also fixing an issue where we used the wrong system_port key on
single-asic VOQ systems

Signed-off-by: Nathan Wolfe <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants