Fix QOS tests to run on 64p topo#23325
Open
arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
Open
Fix QOS tests to run on 64p topo#23325arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
arista-nwolfe wants to merge 1 commit intosonic-net:masterfrom
Conversation
Also fixing an issue where we used the wrong system_port key on single-asic VOQ systems Signed-off-by: Nathan Wolfe <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Mar 26, 2026
Collaborator
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
64 port topos like
topo_t2_single_node_max_64pandtopo_t2_single_node_max_64p_v2won't runqos/test_qos_sai.pybecause the skip conditionals explicitly call out the topology names:This change will group any topo with
t2_single_node*in the condition.Also fixing an issue where we used the wrong system_port key on single-asic VOQ systems.
Without this we see the following failures:
It's trying to read the key
QUEUE|Ethernet0|3when it should beQUEUE|ctn101|Asic0|Ethernet0|3.I believe this was an oversight when #20544 was added (only supports multi_asic).
Instead the conditional should've been more like #7823 and hardcode the
Asic0in the case of single-asic systems.Type of change
Back port request