Skip to content

add support for virtual testbed#774

Merged
lguohan merged 32 commits intosonic-net:masterfrom
lguohan:vstb
Jan 17, 2019
Merged

add support for virtual testbed#774
lguohan merged 32 commits intosonic-net:masterfrom
lguohan:vstb

Conversation

@lguohan
Copy link
Contributor

@lguohan lguohan commented Jan 15, 2019 •
edited
Loading

Description of PR

Virtual testbed a testbed that is built around kvm image. It built a sonic testbed that is similar physical testbed.

Summary:
Fixes # (issue)

Type of change

  • [] Bug fix
  • Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

The main change here is to decouple the interface binding in vm_topology.py library. The change introduces kvm_port.py and vlan_port.py to get/create/remove the interfaces that are used to bind/unbind with the vm and ptf docker.

How did you verify/test it?

Test it on both virtual testbed and physical testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lguohan lguohan force-pushed the vstb branch 3 times, most recently from 0c83cb9 to ae23496 Compare January 15, 2019 08:43
lguohan added 26 commits January 15, 2019 08:56
@lguohan
move external interface configuration into external_port.yml
ad848a0 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
move docker tasks into docker.yml
95530d2 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
move lab proxy from group_var/vm_host to group_var/all/env.yml
94d60ba 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add user to libvirt and docker group
5aad6c2 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
use absolute path for disk_image and cdrom_image
2f49783 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
remove vlan sub-interface creation/removal from vm_topology.py
e5c9444 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add playbook to create sonic vm
57d92aa 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
change all driver to be e1000, then all interfaces are enumerated
24e5ffd 
in order in the guest OS. eth0 is the mangement port

Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add sonic kickstart to configure sonic mgmt ip
25ac52e 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add support to bind vm to kvm vm
a914a06 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
various fixes in the playbook
039ce45 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
fix remove topo
a1576fc 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
handle different init sonic password
eee840a 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
simply fixes
a4ac85d 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
do not create local minigraph
45f9e49 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add inventory files for kvm testbed
23371ff
@lguohan
add missing vlan_port.py
f8712ff 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add proxy env for downloading data
2f1cb58 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
rename external_iface to external_port
aa85c0f 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add ansible_user to sudo group
b99e757 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
fix register name not to be the same as the external_port
f1a78b0 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
correct vlan_port inputs
b20e213 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add become=yes for virt module
9eb4af1 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add vlan create/remove logic for {add,remove}_topo
9ede8be
@lguohan
set dut_mgmt_port to empty for physical dut
02ec9d3
@lguohan
start/stop vm when the dut is kvm type
757899d 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
add vlan_port module to get/create/remove vlan tunnel port in
23d9aa6 
the test server
@lguohan
Revert "add inventory files for kvm testbed"
3b52105 
This reverts commit 49fdbf89e21f37efcf2e505de9c9314ab12006c5.
@lguohan
run kvm_port in privileged mode to run virsh
900b7c0 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan
allow to use user-defined testbed csv and vm inventory file
7b1600b 
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan lguohan force-pushed the vstb branch 2 times, most recently from ed094ea to 12434bc Compare January 15, 2019 21:08
@lguohan
add refresh-dut in testbed cli to refresh a sonic kvm image
bb65c27 
in a topology. It deploy the current sonic vm and recreate
a new sonic vm

Signed-off-by: Guohan Lu <gulv@microsoft.com>
pavel-shirshov
pavel-shirshov approved these changes Jan 17, 2019
View reviewed changes
ansible/group_vars/vm_host/main.yml
@@ -1,4 +1,4 @@
root_path: /home/azure/veos-vm
root_path: veos-vm
Copy link
Contributor

@pavel-shirshov pavel-shirshov Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a root path in this case

Copy link
Contributor Author

@lguohan lguohan Jan 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll fix in a separate pr.

@lguohan lguohan merged commit 71d24e8 into sonic-net:master Jan 17, 2019
@yxieca
Copy link
Collaborator

yxieca commented Jan 18, 2019

Made to 201811 branch on 1/18/2019

mykolaf
mykolaf reviewed Aug 5, 2019
View reviewed changes
ansible/doc/README.testbed.VsSetup.md
@@ -0,0 +1,123 @@
# Testbed Setup
Copy link
Contributor

@mykolaf mykolaf Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lguohan . Is there a list of tests which are supported on this virtual testbed?

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811][utilities][swss] advance sub module head (sonic-net#3481)
e9037a7 
Submodule src/sonic-swss 24fcbb6..3cee6b8:
  > [aclorch]: Fix table name in counter table for mirror rules (sonic-net#1060)
  > Cannot ping to link-local ipv6 interface address of the switch. (sonic-net#774)
  > [MirrorOrch]: Mirror Session Retention across Warm Reboot (sonic-net#1062)

Submodule src/sonic-utilities afaedb7..a06bee7:
  > [201811][config] Add '-h' and '-?' as help options to unify with show/sonic-clear cmds (sonic-net#654)
  > Revert "Fixed config Asym PFC CLI. (sonic-net#632)" (sonic-net#652)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mykolaf mykolaf mykolaf left review comments

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lguohan @yxieca @pavel-shirshov @mykolaf