[test] Add check neighbors health for SONiC neighbor devices#3481
Merged
Pterosaur merged 1 commit intosonic-net:masterfrom Jun 28, 2021
Merged
[test] Add check neighbors health for SONiC neighbor devices#3481Pterosaur merged 1 commit intosonic-net:masterfrom
Pterosaur merged 1 commit intosonic-net:masterfrom
Conversation
fdf78d4 to
4e340df
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Ze Gan <ganze718@gmail.com>
4e340df to
d592c1d
Compare
wangxin
reviewed
Jun 18, 2021
| """ | ||
|
|
||
| vm_base = int(tbinfo['vm_base'][2:]) | ||
| neighbor_type = request.config.getoption("--neighbor_type") |
Collaborator
There was a problem hiding this comment.
Is there a way to detect the type of neighbor? Then the "--neighbor_type" option would be unnecessary. It would be easier to trigger tests.
Contributor
Author
There was a problem hiding this comment.
I don't have any elegant idea to check the type of neighbor.
In my mind, we can only get the type after we login the device, but the password and username is different between EOS and SONiC, so it requires that we need to know the type before we login the device.
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jun 24, 2021
wangxin
approved these changes
Jun 28, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Ze Gan <ganze718@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan ganze718@gmail.com
Description of PR
./run_tests.sh -E -n vms-kvm-t0 -d vlab-01 -c test_nbr_health.py -f vtestbed.csv -i veos_vtb -e "--neighbor_type=sonic"
Summary:
Add test for neighbor health if the neighbor devices are SONiC
Type of change
Approach
What is the motivation for this PR?
To check the neighbor health if the neighbor devices are SONiC
How did you do it?
Add a command argument of pytest to indicate the neighbor device type so that we can choose different flow when we check the neighbor health.
How did you verify/test it?
./run_tests.sh -n vms-kvm-t0 -d vlab-01 -c bgp/test_bgp_fact.py -f vtestbed.csv -i veos_vtb -e "--neighbor_type=sonic"Any platform specific information?
None
Supported testbed topology if it's a new test case?
None
Documentation