Skip to content

Fix key Error in tunnel qos test#7628

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_platform_asic_and_asic_id
Mar 3, 2023
Merged

Fix key Error in tunnel qos test#7628
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_platform_asic_and_asic_id

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Mar 2, 2023

Description of PR

Summary:
Fixes # (issue)
This PR is to fix key Error

Traceback (most recent call last):
  File \"saitests/py3/sai_base_test.py\", line 145, in setUp
  ThriftInterface.setUp(self)
  File \"saitests/py3/sai_base_test.py\", line 50, in setUp
  self.asic_id = self.test_params['asic_id']
  KeyError: 'asic_id'

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

This PR is to fix key Error introduced by #7079

How did you do it?

  1. Add platform_asic in arguments (not necessary after PR assign None to platform_asic as default value when it not exist in test params #7606
  2. Assign None to asic_id if absent.

How did you verify/test it?

Verified on a dualtor testbed.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Mar 2, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/qos/test_tunnel_qos_remap.py
Fixing tests/qos/tunnel_qos_remap_base.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/test_tunnel_qos_remap.py:6:1: F401 'tests.common.fixtures.ptfhost_utils.copy_ptftests_directory' imported but unused
tests/qos/test_tunnel_qos_remap.py:7:1: F401 'tests.common.fixtures.ptfhost_utils.copy_saitests_directory' imported but unused
tests/qos/test_tunnel_qos_remap.py:8:1: F401 'tests.common.fixtures.ptfhost_utils.change_mac_addresses' imported but unused
tests/qos/test_tunnel_qos_remap.py:9:1: F401 'tests.common.fixtures.ptfhost_utils.run_icmp_responder' imported but unused
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@bingwang-ms bingwang-ms merged commit c7984bb into sonic-net:master Mar 3, 2023
yxieca pushed a commit that referenced this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants