[J2C+] QoS/PFC test fixes for SONIC chassis#7079
Merged
vmittal-msft merged 7 commits intosonic-net:masterfrom Feb 15, 2023
Merged
[J2C+] QoS/PFC test fixes for SONIC chassis#7079vmittal-msft merged 7 commits intosonic-net:masterfrom
vmittal-msft merged 7 commits intosonic-net:masterfrom
Conversation
vmittal-msft
force-pushed
the
vmittal/chassis
branch
from
07b4d92 to
301e255
Compare
Additional changes for QoS tests
ansrajpu-git
force-pushed
the
vmittal/chassis
branch
from
5c6a4a7 to
e29d826
Compare
sanmalho-git
previously approved these changes
Jan 30, 2023
sanmalho-git
approved these changes
Feb 15, 2023
tjchadaga
approved these changes
Feb 15, 2023
sanmalho-git
pushed a commit
to sanmalho-git/sonic-mgmt
that referenced
this pull request
Feb 15, 2023
* QoS test fixes for chassis ----------------------------------------------------------- Co-authored-by: ansrajpu <anshu.rajput@nokia.com>
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Feb 17, 2023
* QoS test fixes for chassis ----------------------------------------------------------- Co-authored-by: ansrajpu <anshu.rajput@nokia.com>
6 tasks
Collaborator
|
@vmittal-msft this commit break the T1 test_fib case, below is the err msg |
nhe-NV
added a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
Feb 22, 2023
In ptfhost_utils.py, after PR sonic-net#7079 merged, there is exception "UnboundLocalError: local variable 'dut_port' referenced before assignment"
yaqiangz
pushed a commit
that referenced
this pull request
Feb 22, 2023
In ptfhost_utils.py, after PR #7079 merged, there is exception "UnboundLocalError: local variable 'dut_port' referenced before assignment" How did you do it? Fix the local variable 'dut_port' referenced before assignment How did you verify/test it? Run the test case which has such failure, and it pass.
wangxin
pushed a commit
that referenced
this pull request
Feb 23, 2023
In ptfhost_utils.py, after PR #7079 merged, there is exception "UnboundLocalError: local variable 'dut_port' referenced before assignment" How did you do it? Fix the local variable 'dut_port' referenced before assignment How did you verify/test it? Run the test case which has such failure, and it pass.
6 tasks
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
* QoS test fixes for chassis ----------------------------------------------------------- Co-authored-by: ansrajpu <anshu.rajput@nokia.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
QoS test fixes for SONIC chassis
Back port request
Approach
What is the motivation for this PR?
QoS/PFC test case fixes for SONIC chassis
How did you do it?
Updated test params as well as test infra improvements
How did you verify/test it?
On J2C+ based DUT. Also, verified these changes are not impacting existing T0 toplogies.
Any platform specific information?
Supported testbed topology if it's a new test case?
T2
Documentation
Related to #6946